From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Jaroslav Kysela <perex@perex.cz>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: sound/oss-msnd-pinnacle: ioctl needs the inode
Date: Wed, 14 Jul 2010 15:15:43 +0200 [thread overview]
Message-ID: <s5h8w5e4328.wl%tiwai@suse.de> (raw)
In-Reply-To: <201007141511.39507.arnd@arndb.de>
At Wed, 14 Jul 2010 15:11:39 +0200,
Arnd Bergmann wrote:
>
> This broke in sound/oss: convert to unlocked_ioctl, when I missed one
> of the ioctl functions still using the inode pointer.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied now. Thanks.
Takashi
> ---
> On Tuesday 13 July 2010, Randy Dunlap wrote:
> > On Tue, 13 Jul 2010 14:40:07 +1000 Stephen Rothwell wrote:
> >
> > > Hi all,
> > >
> > > Not unexpectedly, we got some conflicts with the arm defconfig files
> > > today ...
> >
> >
> > sound/oss/msnd_pinnacle.c:644:error: 'inode' undeclared (first use in this function)
> >
>
> Sorry about that, my fault. Please apply.
>
> I checked all the other files I touched in the same patch, they either did
> not have this problem, or I had done it correctly.
>
> --- a/sound/oss/msnd_pinnacle.c
> +++ b/sound/oss/msnd_pinnacle.c
> @@ -641,7 +641,7 @@ static int mixer_ioctl(unsigned int cmd, unsigned long arg)
>
> static long dev_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> {
> - int minor = iminor(inode);
> + int minor = iminor(file->f_path.dentry->d_inode);
> int ret;
>
> if (cmd == OSS_GETVERSION) {
>
next prev parent reply other threads:[~2010-07-14 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 4:40 linux-next: Tree for July 13 Stephen Rothwell
2010-07-13 17:36 ` linux-next: Tree for July 13 (sound/oss/msnd_pinnacle) Randy Dunlap
2010-07-14 13:11 ` sound/oss-msnd-pinnacle: ioctl needs the inode Arnd Bergmann
2010-07-14 13:15 ` Takashi Iwai [this message]
2010-07-14 15:54 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8w5e4328.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=perex@perex.cz \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).