From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] fix build error of driver/mfd/tc6393xb.c Date: Mon, 07 Jul 2008 18:23:44 +0200 Message-ID: References: <200807051013.10078.david-b@pacbell.net> <200807070919.05305.david-b@pacbell.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.suse.de ([195.135.220.2]:45262 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753509AbYGGQXt (ORCPT ); Mon, 7 Jul 2008 12:23:49 -0400 In-Reply-To: <200807070919.05305.david-b@pacbell.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: David Brownell Cc: Dmitry Baryshkov , Stephen Rothwell , linux-next@vger.kernel.org, LKML At Mon, 7 Jul 2008 09:19:05 -0700, David Brownell wrote: >=20 > On Monday 07 July 2008, Takashi Iwai wrote: > >=20 > > > The most natural fix is to have the Kconfig for PPC_MPC52xx > > > select both GENERIC_GPIO and HAVE_GPIO_LIB. > >=20 > > Yes. =A0I, however, still feel uneasy by the fact that the combinat= ion > > GENERIC_GPIO=3Dn and HAVE_GPIO_LIB=3Dy doesn't work. =A0We should e= ither fix > > it to work or disallow the combination. >=20 > As in, HAVE_GPIO_LIB depends on GENERIC_GPIO? Fine with me; > but I'm not sure that would work. Won't Kconfig gleefully let > the "select" succeed but not select what it depends on? No, it's a known problem of kbuild. You can use "select" for select. So, adding "select GENERIC_GPIO" to HAVE_GPIO_LIB should work. But, I'm not sure whether this is the right fix, too... Anyway, adding GENERIC_GPIO is fine as a workaround as now. I'll resubmit the fix patch. I just wanted you to keep the remaining problem in mind. thanks, Takashi