From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: linux-next: Tree for August 13
Date: Wed, 13 Aug 2008 15:37:15 +0200
Message-ID: <s5hwsil829g.wl%tiwai@suse.de>
References: <20080813172452.14b0775c.sfr@canb.auug.org.au>
	<s5h7ial9nvm.wl%tiwai@suse.de>
	<20080813140811.030bb766@lxorguk.ukuu.org.uk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1755517AbYHMNhd@vger.kernel.org>
In-Reply-To: <20080813140811.030bb766@lxorguk.ukuu.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
List-Id: linux-next.vger.kernel.org

At Wed, 13 Aug 2008 14:08:11 +0100,
Alan Cox wrote:
> 
> > When re-starting X, it complains that it cannot change to VT7.
> > Via strace, 
> 
> Does this fix it
> 
> @@ -838,6 +839,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)
>  void __cleanup_signal(struct signal_struct *sig)
>  {
>  	exit_thread_group_keys(sig);
> +	tty_kref_put(sig->tty);
>  	kmem_cache_free(signal_cachep, sig);
>  }

Thanks, will give it a try.

The above can't be applied as is to next tree, so the following is
applied instead.


Takashi
---
diff --git a/kernel/fork.c b/kernel/fork.c
index 600a264..2353660 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -834,6 +834,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)
 
 void __cleanup_signal(struct signal_struct *sig)
 {
+	tty_kref_put(sig->tty);
 	kmem_cache_free(signal_cachep, sig);
 }