From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-nfc@lists.01.org
Subject: [linux-nfc] Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers
Date: Thu, 26 Nov 2020 18:01:54 +0100 [thread overview]
Message-ID: <20201126170154.GA4978@kozik-lap> (raw)
In-Reply-To: 1606404819-30647-1-git-send-email-bongsu.jeon@samsung.com
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Fri, Nov 27, 2020@12:33:37AM +0900, bongsu.jeon2@gmail.com wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
>
> GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - are
> signed integers, where negative number indicates error. The return
> value of of_get_named_gpio() should not be assigned to an unsigned int
> because in case of !CONFIG_GPIOLIB such number would be a valid GPIO.
>
> Fixes: c04c674fadeb ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Why do you send my patch?
Best regards,
Krzysztof
next reply other threads:[~2020-11-26 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 17:01 Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-27 5:41 [linux-nfc] Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers Bongsu Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126170154.GA4978@kozik-lap \
--to=krzk@kernel.org \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).