From: "Steve Wise" <swise@opengridcomputing.com>
To: <trond.myklebust@primarydata.com>, <bfields@fieldses.org>
Cc: <linux-nfs@vger.kernel.org>, <tom@opengridcomputing.com>,
"Chuck Lever" <chuck.lever@oracle.com>
Subject: RE: [PATCH] Fix regression errors in NFSRDMA
Date: Tue, 25 Mar 2014 12:27:10 -0500 [thread overview]
Message-ID: <004e01cf484f$73f1b3b0$5bd51b10$@opengridcomputing.com> (raw)
In-Reply-To: <20140325145044.3559.95141.stgit@build.ogc.int>
> The client regression was due to additional XDR sanity checking
> (64bd577ea0021f5903505de061b3b7d8a785ee94) that exposed a latent bug in
> the NFSRDMA client. The bug is that if there were inline data, then the
> rpcrdma_fixup_inline function would would incorrectly set the XDR page_len
> to zero. Since the decode_read3resok logic previously computed this
> value from the reported len - header len, the bug was not symptomatic.
Oops: The client bug has already been fixed by Chuck's patch which is already
in Trond's nfs-for-next branch:
----
commit 2b7bbc963da8d076f263574af4138b5df2e1581f
Author: Chuck Lever <chuck.lever@oracle.com>
Date: Wed Mar 12 12:51:30 2014 -0400
SUNRPC: Fix large reads on NFS/RDMA
----
So I'll repost Tom's server-side fix, after applying it on nfs-for-next and verifying things
still work.
Steve.
next prev parent reply other threads:[~2014-03-25 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 14:50 [PATCH] Fix regression errors in NFSRDMA Steve Wise
2014-03-25 17:27 ` Steve Wise [this message]
2014-04-02 17:46 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004e01cf484f$73f1b3b0$5bd51b10$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tom@opengridcomputing.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).