* [PATCH V2] svcrdma: Fence LOCAL_INV work requests
@ 2014-06-05 14:54 Steve Wise
2014-06-05 16:13 ` J. Bruce Fields
0 siblings, 1 reply; 3+ messages in thread
From: Steve Wise @ 2014-06-05 14:54 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs, linux-rdma, tom
This applies on top of:
commit e5a070216356dbcb03607cb264cc3104e17339b3
Author: Steve Wise <swise@opengridcomputing.com>
Date: Wed May 28 15:12:01 2014 -0500
svcrdma: refactor marshalling logic
Fencing forces the invalidate to only happen after all prior send
work requests have been completed.
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
index 52d9f2c..8f92a61 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
@@ -338,7 +338,7 @@ static int rdma_read_chunk_frmr(struct svcxprt_rdma *xprt,
memset(&inv_wr, 0, sizeof(inv_wr));
inv_wr.wr_id = (unsigned long)ctxt;
inv_wr.opcode = IB_WR_LOCAL_INV;
- inv_wr.send_flags = IB_SEND_SIGNALED;
+ inv_wr.send_flags = IB_SEND_SIGNALED | IB_SEND_FENCE;
inv_wr.ex.invalidate_rkey = frmr->mr->lkey;
}
ctxt->wr_op = read_wr.opcode;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] svcrdma: Fence LOCAL_INV work requests
2014-06-05 14:54 [PATCH V2] svcrdma: Fence LOCAL_INV work requests Steve Wise
@ 2014-06-05 16:13 ` J. Bruce Fields
2014-06-05 16:21 ` Steve Wise
0 siblings, 1 reply; 3+ messages in thread
From: J. Bruce Fields @ 2014-06-05 16:13 UTC (permalink / raw)
To: Steve Wise; +Cc: linux-nfs, linux-rdma, tom
On Thu, Jun 05, 2014 at 09:54:31AM -0500, Steve Wise wrote:
> This applies on top of:
>
> commit e5a070216356dbcb03607cb264cc3104e17339b3
> Author: Steve Wise <swise@opengridcomputing.com>
> Date: Wed May 28 15:12:01 2014 -0500
>
> svcrdma: refactor marshalling logic
Sorry, I lost track--was there another revision of that patch coming
too?
--b.
>
> Fencing forces the invalidate to only happen after all prior send
> work requests have been completed.
>
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> ---
>
> net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> index 52d9f2c..8f92a61 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> @@ -338,7 +338,7 @@ static int rdma_read_chunk_frmr(struct svcxprt_rdma *xprt,
> memset(&inv_wr, 0, sizeof(inv_wr));
> inv_wr.wr_id = (unsigned long)ctxt;
> inv_wr.opcode = IB_WR_LOCAL_INV;
> - inv_wr.send_flags = IB_SEND_SIGNALED;
> + inv_wr.send_flags = IB_SEND_SIGNALED | IB_SEND_FENCE;
> inv_wr.ex.invalidate_rkey = frmr->mr->lkey;
> }
> ctxt->wr_op = read_wr.opcode;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH V2] svcrdma: Fence LOCAL_INV work requests
2014-06-05 16:13 ` J. Bruce Fields
@ 2014-06-05 16:21 ` Steve Wise
0 siblings, 0 replies; 3+ messages in thread
From: Steve Wise @ 2014-06-05 16:21 UTC (permalink / raw)
To: 'J. Bruce Fields'; +Cc: linux-nfs, linux-rdma, tom
> -----Original Message-----
> From: J. Bruce Fields [mailto:bfields@fieldses.org]
> Sent: Thursday, June 05, 2014 11:14 AM
> To: Steve Wise
> Cc: linux-nfs@vger.kernel.org; linux-rdma@vger.kernel.org; tom@opengridcomputing.com
> Subject: Re: [PATCH V2] svcrdma: Fence LOCAL_INV work requests
>
> On Thu, Jun 05, 2014 at 09:54:31AM -0500, Steve Wise wrote:
> > This applies on top of:
> >
> > commit e5a070216356dbcb03607cb264cc3104e17339b3
> > Author: Steve Wise <swise@opengridcomputing.com>
> > Date: Wed May 28 15:12:01 2014 -0500
> >
> > svcrdma: refactor marshalling logic
>
> Sorry, I lost track--was there another revision of that patch coming
> too?
>
No.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-05 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-05 14:54 [PATCH V2] svcrdma: Fence LOCAL_INV work requests Steve Wise
2014-06-05 16:13 ` J. Bruce Fields
2014-06-05 16:21 ` Steve Wise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).