From: "Steve Wise" <swise@opengridcomputing.com>
To: "'J. Bruce Fields'" <bfields@fieldses.org>
Cc: <trond.myklebust@primarydata.com>, <linux-nfs@vger.kernel.org>,
<linux-rdma@vger.kernel.org>
Subject: RE: [PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset
Date: Mon, 28 Sep 2015 16:49:21 -0500 [thread overview]
Message-ID: <009001d0fa37$8871a980$9954fc80$@opengridcomputing.com> (raw)
In-Reply-To: <20150928210459.GC3190@fieldses.org>
> -----Original Message-----
> From: J. Bruce Fields [mailto:bfields@fieldses.org]
> Sent: Monday, September 28, 2015 4:05 PM
> To: Steve Wise
> Cc: trond.myklebust@primarydata.com; linux-nfs@vger.kernel.org; linux-rdma@vger.kernel.org
> Subject: Re: [PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset
>
> On Mon, Sep 28, 2015 at 09:31:25AM -0500, Steve Wise wrote:
> > On 9/21/2015 12:24 PM, Steve Wise wrote:
> > >The server rdma_read_chunk_lcl() and rdma_read_chunk_frmr() functions
> > >were not taking into account the initial page_offset when determining
> > >the rdma read length. This resulted in a read who's starting address
> > >and length exceeded the base/bounds of the frmr.
> > >
> > >Most work loads don't tickle this bug apparently, but one test hit it
> > >every time: building the linux kernel on a 16 core node with 'make -j
> > >16 O=/mnt/0' where /mnt/0 is a ramdisk mounted via NFSRDMA.
> > >
> > >This bug seems to only be tripped with devices having small fastreg page
> > >list depths. I didn't see it with mlx4, for instance.
> > >
> > >Fixes: 0bf4828983df ('svcrdma: refactor marshalling logic')
> > >Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> > >Tested-by: Chuck Lever <chuck.lever@oracle.com>
> > >---
> > >
> > >
> >
> > Hey Bruce, can this make 4.3-rc? Also, what do you think about
> > pushing it to stable?
>
> It looks like a reasonable candidate for stable. Apologies, somehow I
> missed it when you posted it--would you mind resending?
>
> --b.
resent this one patch.
What is your process for pushing to stable?
Thanks,
Steve.
next prev parent reply other threads:[~2015-09-28 21:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 17:24 [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers Steve Wise
2015-09-21 17:24 ` [PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset Steve Wise
2015-09-28 14:31 ` Steve Wise
2015-09-28 21:04 ` J. Bruce Fields
2015-09-28 21:49 ` Steve Wise [this message]
2015-09-29 15:40 ` 'J. Bruce Fields'
2015-09-21 17:24 ` [PATCH 3/3] xprtrdma: don't log warnings for flushed completions Steve Wise
2015-09-28 14:30 ` [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers Steve Wise
2015-09-28 14:45 ` Anna Schumaker
2015-09-28 14:50 ` Steve Wise
2015-09-28 14:57 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009001d0fa37$8871a980$9954fc80$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).