RE: [PATCH 4/4] 4.1 create_session: Skip test of CB_NULL for nfs4.1

["Frank Filz" <ffilzlnx@mindspring.com>]

> On Tue, Jul 28, 2015 at 09:03:38AM -0700, Frank Filz wrote:
> > Why are we removing these two test cases? The Ganesha NFS server at
> least passes them.
> 
> And there's nothing wrong with passing the tests, but unfortunately
there's
> not necessarily anything wrong with failing either: a 4.1 server isn't
required
> to do a NULL callback to probe the backchannel.
> 
> There might be a better test (depend on delegation recalls instead of
> CB_NULL's?), till then I'm OK with turning them off by default.

I guess I'd at least like to see some explanation of why we're turning the
tests off by default. I'm just resistant to removing testing for no reason.

If the test doesn't actually test anything useful, that would be one
explanation.

If it's something that's not required and not all servers do it, then that's
another explanation.

There might be other explanations, just please give some insight.

Thanks

Frank

> > > -----Original Message-----
> > > From: linux-nfs-owner@vger.kernel.org [mailto:linux-nfs-
> > > owner@vger.kernel.org] On Behalf Of Kinglong Mee
> > > Sent: Tuesday, July 28, 2015 4:47 AM
> > > To: J. Bruce Fields; linux-nfs@vger.kernel.org
> > > Cc: tigran.mkrtchyan@desy.de; kinglongmee@gmail.com
> > > Subject: [PATCH 4/4] 4.1 create_session: Skip test of CB_NULL for
> > > nfs4.1
> > >
> > > Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> > > ---
> > >  nfs4.1/server41tests/st_create_session.py | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/nfs4.1/server41tests/st_create_session.py
> > > b/nfs4.1/server41tests/st_create_session.py
> > > index b42e0ab..4c56bb4 100644
> > > --- a/nfs4.1/server41tests/st_create_session.py
> > > +++ b/nfs4.1/server41tests/st_create_session.py
> > > @@ -333,7 +333,7 @@ def testManyClients(t, env):
> > >  def testCallbackProgram(t, env):
> > >      """Check server can handle random transient program number
> > >
> > > -    FLAGS: create_session all
> > > +    FLAGS:
> > >      CODE: CSESS20
> > >      """
> > >      cb_occurred = threading.Event() @@ -360,7 +360,7 @@ def
> > > testCallbackProgram(t, env):
> > >  def testCallbackVersion(t, env):
> > >      """Check server sends callback program with a version listed in
> > > nfs4client.py
> > >
> > > -    FLAGS: create_session all
> > > +    FLAGS:
> > >      CODE: CSESS21
> > >      """
> > >      cb_occurred = threading.Event()
> > > --
> > > 2.4.3
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-nfs"
> > > in the body of a message to majordomo@vger.kernel.org More
> majordomo
> > > info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html