From: "Frank Filz" <ffilzlnx@mindspring.com>
To: "'J. Bruce Fields'" <bfields@redhat.com>
Cc: "'Tom Haynes'" <loghyr@primarydata.com>,
"'Linux NFS Mailing list'" <linux-nfs@vger.kernel.org>
Subject: RE: [PATCH pynfs 00/12] Flex File support
Date: Wed, 30 Nov 2016 08:56:38 -0800 [thread overview]
Message-ID: <018401d24b2a$b8037670$280a6350$@mindspring.com> (raw)
In-Reply-To: <20161130142412.GA18463@parsley.fieldses.org>
> > > -----Original Message-----
> > > From: linux-nfs-owner@vger.kernel.org [mailto:linux-nfs-
> > > owner@vger.kernel.org] On Behalf Of J. Bruce Fields
> > > Sent: Monday, November 28, 2016 8:33 AM
> > > To: Tom Haynes <loghyr@primarydata.com>
> > > Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
> > > Subject: Re: [PATCH pynfs 00/12] Flex File support
> > >
> > > On Sat, Nov 26, 2016 at 10:26:29PM -0800, Tom Haynes wrote:
> > > > I wanted to add client support for the flex file layout.
> > > >
> > > > Note, I did not add pynfs as a flag because I didn't want to mess
> > > > up with any existing uses of it.
> > > >
> > > > The other major change here is in closing all opened files and
> > > > destroying all clientids. With all the tests which run against my
> > > > server, there are no longer any open files. There are however 11
> > > > clientids remaining.
> > > >
> > > > I will track those down.
> > > >
> > > > fwiw - these are in my staging branch at
> > > > git://linux-nfs.org/~loghyr/pynfs.git
> > >
> > > Thanks! I'll try these and take a look.
> > >
> > > How did you notice all the leftover state? I run with a pretty
> > > short
> > lease time
> > > (to speed testing), so I guess the leftover state must expire too
> > > quickly
> > to
> > > cause me problems.
> > >
> > > Anyway it's good to have that cleaned up.
> >
> > Not closing files and releasing clientids at least in the 4.0 tests
> > has actually shaken out bugs in Ganesha...
> >
> > But maybe that kind of thing should be an explicit test, create lots
> > of clientids/sessions, and then wait for them all to expire and see if
> > the server can handle all the activity.
>
> Yes, probably so.
>
> I seem to recall this not being the first time this has caused problems
for
> people with test scripts that try to unmount immediately after running
pynfs.
Yea... One option would be for pynfs to delay for the lease period (or maybe
twice the lease period) after the last test.
One nice thing (and now that you mention it, I'm pretty sure we've had this
conversation before) about the status quo is that the lease expiry for
earlier tests happens in the middle of other tests. Maybe not so nice an
deterministic for the test suite, but great at exposing issues...
Frank
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
prev parent reply other threads:[~2016-11-30 16:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 6:26 [PATCH pynfs 00/12] Flex File support Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 01/12] According to RFC7863, this is not an array Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 02/12] Close the files opened in the OPEN tests Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 03/12] Some more file closes to cleanup state on the server Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 04/12] Get rid of the client records as well as the session records Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 05/12] Really, really close those open temp files to remove state on the server Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 06/12] Add xdr for Flex Files Layout Type Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 07/12] Simple tests of the flex file layout type Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 08/12] Add a check to see if NFS4ERR_OLD_STATEID is issued on concurrent layoutgets Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 09/12] Check that the flex file access uid/gid are correct for the different iomodes Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 10/12] FFLS1: Simulate LAYOUTSTATS for 20 small file creations Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 11/12] Factor out checking seqid for flex file layouts Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 12/12] Add layoutstats tests for flex files Tom Haynes
2016-11-28 17:22 ` J. Bruce Fields
2016-11-28 17:52 ` Tom Haynes
2016-11-28 16:33 ` [PATCH pynfs 00/12] Flex File support J. Bruce Fields
2016-11-28 16:53 ` Tom Haynes
2016-11-28 21:47 ` J. Bruce Fields
2016-11-28 23:38 ` Tom Haynes
2016-11-29 1:55 ` J. Bruce Fields
2016-11-29 23:44 ` Frank Filz
2016-11-30 14:24 ` J. Bruce Fields
2016-11-30 16:56 ` Frank Filz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='018401d24b2a$b8037670$280a6350$@mindspring.com' \
--to=ffilzlnx@mindspring.com \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=loghyr@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).