Re: [PATCHES] nfsctl fix and cleanups

[Jeff Layton <jlayton@kernel.org>]

On Thu, 2025-09-11 at 23:44 +0100, Al Viro wrote:
> 	More stuff pulled out of tree-in-dcache pile, this time nfsctl.
> The first one in the series is a fix for minor bogosity, the rest -
> cleanups.  Elimination of more d_alloc_name() call sites on conversions
> to simple_start_creating() is what got that into preparation parts of
> tree-in-dcache...
> 
> Branch in -rc5-based, lives in
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #work.nfsctl
> individual patches in followups.  If nobody objects, into -next it goes...
> 

(cc'ing Chuck)

Ok, so you're planning to take this in via the vfs tree? Let us know if
you'd rather Chuck do it via nfsd tree.

> Shortlog:
>       nfsctl: symlink has no business bumping link count of parent directory
>       nfsd_mkdir(): switch to simple_start_creating()
>       _nfsd_symlink(): switch to simple_start_creating()
>       nfsdfs_create_files(): switch to simple_start_creating()
>       nfsd_get_inode(): lift setting ->i_{,f}op to callers.
> 
> Diffstat:
>  fs/nfsd/nfsctl.c | 137 ++++++++++++++++++++-----------------------------------
>  1 file changed, 49 insertions(+), 88 deletions(-)

Thanks Al. This all looks great to me.

Reviewed-by: Jeff Layton <jlayton@kernel.org>