From: Weston Andros Adamson <dros@primarydata.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-nfs list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] nfs4: fix comments in discover_server_trunking
Date: Sun, 19 Jan 2014 23:20:52 -0500 [thread overview]
Message-ID: <044F0EF6-E033-4277-AB83-ACFEA739C188@primarydata.com> (raw)
In-Reply-To: <1390189537-9666-2-git-send-email-dros@primarydata.com>
Ignore this patch. I misunderstood the meaning of the original comments...
-dros
On Jan 19, 2014, at 10:45 PM, Weston Andros Adamson <dros@primarydata.com> wrote:
> 'result' is not updated if a match isn't found in the
> nfs4_discover_server_trunking path.
>
> Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
> ---
> fs/nfs/nfs4client.c | 4 ++--
> fs/nfs/nfs4state.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
> index 0f9b772..147a752 100644
> --- a/fs/nfs/nfs4client.c
> +++ b/fs/nfs/nfs4client.c
> @@ -465,7 +465,7 @@ static void nfs4_swap_callback_idents(struct nfs_client *keep,
> * nfs40_walk_client_list - Find server that recognizes a client ID
> *
> * @new: nfs_client with client ID to test
> - * @result: OUT: found nfs_client, or new
> + * @result: OUT: found nfs_client
> * @cred: credential to use for trunking test
> *
> * Returns zero, a negative errno, or a negative NFS4ERR status.
> @@ -601,7 +601,7 @@ out_major_mismatch:
> * nfs41_walk_client_list - Find nfs_client that matches a client/server owner
> *
> * @new: nfs_client with client ID to test
> - * @result: OUT: found nfs_client, or new
> + * @result: OUT: found nfs_client
> * @cred: credential to use for trunking test
> *
> * Returns zero, a negative errno, or a negative NFS4ERR status.
> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
> index e5be725..666512e 100644
> --- a/fs/nfs/nfs4state.c
> +++ b/fs/nfs/nfs4state.c
> @@ -328,7 +328,7 @@ out:
> * nfs41_discover_server_trunking - Detect server IP address trunking (mv1)
> *
> * @clp: nfs_client under test
> - * @result: OUT: found nfs_client, or clp
> + * @result: OUT: found nfs_client
> * @cred: credential to use for trunking test
> *
> * Returns NFS4_OK, a negative errno, or a negative NFS4ERR status.
> --
> 1.8.3.4 (Apple Git-47)
>
next prev parent reply other threads:[~2014-01-20 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390189537-9666-1-git-send-email-dros@primarydata.com>
2014-01-20 3:45 ` [PATCH 2/2] nfs4: fix comments in discover_server_trunking Weston Andros Adamson
2014-01-20 4:20 ` Weston Andros Adamson [this message]
2014-01-20 23:32 ` [PATCH 1/2] nfs4: fix discover_server_trunking use after free Trond Myklebust
2014-01-21 15:04 ` Weston Andros Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=044F0EF6-E033-4277-AB83-ACFEA739C188@primarydata.com \
--to=dros@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox