From: Steve Dickson <steved@redhat.com>
To: Charles Hedrick <hedrick@rutgers.edu>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: probable big in nfs-utils
Date: Fri, 4 Oct 2024 15:54:46 -0400 [thread overview]
Message-ID: <0654ecc2-74fa-4e50-8878-bf37f17a5748@redhat.com> (raw)
In-Reply-To: <PH0PR14MB5493F5F79BCAE03BF2C25ED6AA722@PH0PR14MB5493.namprd14.prod.outlook.com>
Hello,
On 10/4/24 2:14 PM, Charles Hedrick wrote:
> While looking into a problem that turns out to be somewhere else, I noticed that in gssd_proc.c , getpwuid is used. The context is threaded, and I verified with strace that the thread is sharing memory with other threads. I believe this should be changed to getpwuid_r. Similarly the following call to getpwnam.
>
> Is this the right place for reports on nfs-utils?
Yes... but I'm not a fan of change code, that been around
for a while, without fixing a problem... What problem does changing
getpwuid to getpwuid_r fix?
Patches are always welcome!
steved.
next prev parent reply other threads:[~2024-10-04 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 18:14 probable big in nfs-utils Charles Hedrick
2024-10-04 19:54 ` Steve Dickson [this message]
2024-10-05 2:41 ` Ian Kent
2024-10-05 2:47 ` Ian Kent
2024-10-05 2:52 ` Ian Kent
2024-10-05 2:58 ` Ian Kent
2024-10-06 12:43 ` Steve Dickson
2024-10-06 23:53 ` Ian Kent
2024-10-18 13:10 ` Steve Dickson
2024-10-18 23:19 ` Ian Kent
2024-10-19 12:40 ` Steve Dickson
2024-10-21 0:46 ` Ian Kent
2024-10-23 0:51 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0654ecc2-74fa-4e50-8878-bf37f17a5748@redhat.com \
--to=steved@redhat.com \
--cc=hedrick@rutgers.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox