From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5514C4332B for ; Thu, 21 Jan 2021 03:52:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DEDB2071C for ; Thu, 21 Jan 2021 03:52:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbhAUDww (ORCPT ); Wed, 20 Jan 2021 22:52:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404050AbhATXxY (ORCPT ); Wed, 20 Jan 2021 18:53:24 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BDD8C061575 for ; Wed, 20 Jan 2021 15:52:38 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id q129so603676iod.0 for ; Wed, 20 Jan 2021 15:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=to:from:cc:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=BQ+C6cxMr+NFXAiwMQZbpz+U43nbXJpB0nxvOmHbDDk=; b=GBSSYqKse4GktCQQv1dhwdvucvIBHv6a/8vYcZZzt8CglYaJuMkWvupsAJ2XJDpCRX sBWqCBvysBMQEml1P36301Da/reVbbo3/GOvU0v0FYphlDUpsy3UvS4H78YcWJLmbkmu E1xXCOfh1iCVA0orsq5z+fa5LtZnuv+0AIF5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:cc:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=BQ+C6cxMr+NFXAiwMQZbpz+U43nbXJpB0nxvOmHbDDk=; b=VeeX+S11sOm5D3R7BYmfFFYcBuyfC6CBhQOOKzdWnaI//3lu+hy0nd6Y1Nv1HhR+vN RkHXp1Fep7Ea9WL+NGE8VzaVsHYmlwp3i3Ku/h8rvB/l3f4BpgC/cIQeCLzcjn+n+C+f CEnWPOEpxtH2PHlpreyLe7T8M6QLBUjXNpNfLGWUJFPwZUM6pe4O7/VuruXEacYz2TdG 5HbXlyxU54LQkFYEYu2A2HN1fq7dh4z+/37kR/uqw6ZqV8sLPyfUidVj/O2ajRANn6rn eNPoQx6NQYTYfVgrgb8GPkDzExfSD4tUBjnuenZpvf8UySeJi3wpZzGuUdGu0PsC0Evv 9wEg== X-Gm-Message-State: AOAM533LbezDcIqmmv6QyHl6nHAfqc6LkGUj40qKwBN0nldZ1YP9RFbZ 4qxBffCBjvnV/xJ16LpCPmoc7A== X-Google-Smtp-Source: ABdhPJyIFhoU6bCVbtrka/8a6fUyKb0QF3oP0zoYmAU7UKS8RIO3TiE/RmGDIOcZPkwKTc1P34hU4Q== X-Received: by 2002:a6b:7f45:: with SMTP id m5mr8559311ioq.180.1611186757822; Wed, 20 Jan 2021 15:52:37 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id a5sm1819555ilq.60.2021.01.20.15.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 15:52:37 -0800 (PST) To: Anna.Schumaker@netapp.com, trond.myklebust@hammerspace.com From: Shuah Khan Cc: "J. Bruce Fields" , chuck.lever@oracle.com, "David S. Miller" , kuba@kernel.org, linux-nfs@vger.kernel.org, Networking , Linux Kernel Mailing List Subject: rpc_xprt_debugfs_register() - atomic_inc_return() usage Message-ID: <06c8f6ff-f821-e909-d40c-9de98657729f@linuxfoundation.org> Date: Wed, 20 Jan 2021 16:52:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Anna and Trond, I came across the following while reviewing atomic_inc_return() usages that cast return value to unsigned rpc_xprt_debugfs_register()'s atomic_inc_return() usage looks a bit odd. - cur_id isn't initialized - id = (unsigned int)atomic_inc_return(&cur_id); Please note that id is int. Is it expected that cur_id could overflow? Is there a maximum limit for this value? thanks, -- Shuah