From: Jeff Layton <jlayton@kernel.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: trondmy@kernel.org, anna@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
Date: Wed, 21 Aug 2024 12:06:09 -0400 [thread overview]
Message-ID: <06fc6f0eab32ea183c5aace43ba08ea6ecfd9cf4.camel@kernel.org> (raw)
In-Reply-To: <74650085-DEEE-4483-8754-EE409649E574@redhat.com>
On Wed, 2024-08-21 at 12:04 -0400, Benjamin Coddington wrote:
> On 15 Aug 2024, at 10:18, Jeff Layton wrote:
>
> > The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the
> > initial
> > SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the initial
> > request.
> >
> > Fixes: 707f13b3d081 (NFSv4: Add support for the
> > FATTR4_OPEN_ARGUMENTS attribute)
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>
> Clearly correct, save for slight style mismatch.
>
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
>
> Ben
>
Thanks. I noticed that after sending it. No objection if you want to
fix that up before merging.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2024-08-21 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 14:18 [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS Jeff Layton
2024-08-21 12:20 ` Jeff Layton
2024-08-21 19:30 ` Anna Schumaker
2024-08-21 16:04 ` Benjamin Coddington
2024-08-21 16:06 ` Jeff Layton [this message]
2024-08-21 16:18 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06fc6f0eab32ea183c5aace43ba08ea6ecfd9cf4.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).