From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TRACKER_ID, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CBA3C64E7C for ; Sun, 22 Nov 2020 16:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A985E2076E for ; Sun, 22 Nov 2020 16:11:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JuTdFtHh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgKVQLQ (ORCPT ); Sun, 22 Nov 2020 11:11:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33757 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727936AbgKVQLF (ORCPT ); Sun, 22 Nov 2020 11:11:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606061463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D4o3+oRulyAmQWJaTM5GlynW0/tmbkOzx3PzhPB5iTg=; b=JuTdFtHhsclSCFUt685nObhejVSN718q0xDzBI7qCmYl4/ObRaglwiPh1kkjwftUYKtjGT F9V7hg+6Ged1Ypc78HlKhU8yURVG+HfY97vOU+FDQTH2+EktMkCoujoBzuPIEBmLFdUcTH U0gcN5s+aBBBeO3IQtZ/9hGSdS8be9I= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-r7pmX_zIMjq0x9tB3i7AcA-1; Sun, 22 Nov 2020 11:11:00 -0500 X-MC-Unique: r7pmX_zIMjq0x9tB3i7AcA-1 Received: by mail-qt1-f197.google.com with SMTP id g17so3740413qtr.8 for ; Sun, 22 Nov 2020 08:11:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=D4o3+oRulyAmQWJaTM5GlynW0/tmbkOzx3PzhPB5iTg=; b=e6gYjmUf81sV3F3F2waP5Z4jwyZuusrfR3Jf8NSm3L/0GMZYgfNnhjMOqVAQArfkpv NMAbe1/Nww8GGCFZodIQmI/yCJfZDIUpD44QD3r5nJYX7llW8Ji0tjD69JG3Q85LQzaQ iYN3H9g2dVj/BEICXKCVEGqScEkVfXltmeIJd4asWOQQaiuDI/obVnwF23HZfTLjT8rM CJGwrvND/NINwpY7yNgV+wO/FZ2K+eWrRZ4okzCXgo5dvy9p9364fPUhK4u72o7T0KUe UQr7us/xXuhO4OhaOnVxcLUwRTjb+d8Xu5rUEI6GIFkClk1ymvYBuLDexkLeEdcSUJiE tQjA== X-Gm-Message-State: AOAM531r9JisnEDywzB+2Uw2XIxT+MdQPQqSO8Oc3AYpd4jVYO41WnzW 4DvQuj1++jYlZLDEgrRB5sppIa0A6IerAFEPtmsbbHvhJssmFn/pSndGCcooARFY2mpGlOexmcb KDvdlVaVj18pMI1Hov5Yi X-Received: by 2002:ac8:5a8c:: with SMTP id c12mr23364794qtc.97.1606061459262; Sun, 22 Nov 2020 08:10:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJw6JfmMkGlJyoaKx6ihYsYbDuDsWkyDwIosiC/apv5eylMrcIvHPxlHVgnFDCnun9WXh4UZ3w== X-Received: by 2002:ac8:5a8c:: with SMTP id c12mr23364770qtc.97.1606061458997; Sun, 22 Nov 2020 08:10:58 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id l3sm2779806qth.13.2020.11.22.08.10.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Nov 2020 08:10:58 -0800 (PST) Subject: Re: [RFC] MAINTAINERS tag for cleanup robot To: Matthew Wilcox Cc: joe@perches.com, clang-built-linux@googlegroups.com, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, tboot-devel@lists.sourceforge.net, kvm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, netdev@vger.kernel.org, linux-media@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, keyrings@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, alsa-devel@alsa-project.org, bpf@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-nfs@vger.kernel.org, patches@opensource.cirrus.com References: <20201121165058.1644182-1-trix@redhat.com> <20201122032304.GE4327@casper.infradead.org> <20201122145635.GG4327@casper.infradead.org> From: Tom Rix Message-ID: <0819ce06-c462-d4df-d3d9-14931dc5aefc@redhat.com> Date: Sun, 22 Nov 2020 08:10:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201122145635.GG4327@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 11/22/20 6:56 AM, Matthew Wilcox wrote: > On Sun, Nov 22, 2020 at 06:46:46AM -0800, Tom Rix wrote: >> On 11/21/20 7:23 PM, Matthew Wilcox wrote: >>> On Sat, Nov 21, 2020 at 08:50:58AM -0800, trix@redhat.com wrote: >>>> The fixer review is >>>> https://reviews.llvm.org/D91789 >>>> >>>> A run over allyesconfig for x86_64 finds 62 issues, 5 are false positives. >>>> The false positives are caused by macros passed to other macros and by >>>> some macro expansions that did not have an extra semicolon. >>>> >>>> This cleans up about 1,000 of the current 10,000 -Wextra-semi-stmt >>>> warnings in linux-next. >>> Are any of them not false-positives? It's all very well to enable >>> stricter warnings, but if they don't fix any bugs, they're just churn. >>> >> While enabling additional warnings may be a side effect of this effort >> >> the primary goal is to set up a cleaning robot. After that a refactoring robot. > Why do we need such a thing? Again, it sounds like more churn. > It's really annoying when I'm working on something important that gets > derailed by pointless churn. Churn also makes it harder to backport > patches to earlier kernels. > A refactoring example on moving to treewide, consistent use of a new api may help. Consider 2efc459d06f1630001e3984854848a5647086232 sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output A new api for printing in the sysfs.  How do we use it treewide ? Done manually, it would be a heroic effort requiring high level maintainers pushing and likely only get partially done. If a refactoring programatic fixit is done and validated on a one subsystem, it can run on all the subsystems. The effort is a couple of weeks to write and validate the fixer, hours to run over the tree. It won't be perfect but will be better than doing it manually. Tom