From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: Yotam Gigi <yotamg@mellanox.com>,
Andy Adamson <andros@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Yotam Gigi <yotam.gi@gmail.com>, mlxsw <mlxsw@mellanox.com>
Subject: Re: nfs NULL-dereferencing in net-next
Date: Wed, 26 Oct 2016 14:17:14 -0400 [thread overview]
Message-ID: <0ab5021c-84eb-cb9f-c7f5-4d856fdb0f4b@Netapp.com> (raw)
In-Reply-To: <20161026190840.3d46dad8@jkicinski-Precision-T1700>
On 10/26/2016 02:08 PM, Jakub Kicinski wrote:
> On Wed, 26 Oct 2016 16:15:24 +0000, Yotam Gigi wrote:
>>> -----Original Message-----
>>> From: Anna Schumaker [mailto:Anna.Schumaker@Netapp.com]
>>> Sent: Wednesday, October 26, 2016 5:40 PM
>>> To: Yotam Gigi <yotamg@mellanox.com>; Jakub Kicinski <kubakici@wp.pl>; Andy
>>> Adamson <andros@netapp.com>; Anna Schumaker
>>> <Anna.Schumaker@Netapp.com>; linux-nfs@vger.kernel.org
>>> Cc: netdev@vger.kernel.org; Trond Myklebust <Trond.Myklebust@netapp.com>;
>>> Yotam Gigi <yotam.gi@gmail.com>; mlxsw <mlxsw@mellanox.com>
>>> Subject: Re: nfs NULL-dereferencing in net-next
>>>
>>> On 10/25/2016 01:19 PM, Yotam Gigi wrote:
>>>>
>>>>> -----Original Message-----
>>>>> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
>>> On
>>>>> Behalf Of Jakub Kicinski
>>>>> Sent: Monday, October 17, 2016 10:20 PM
>>>>> To: Andy Adamson <andros@netapp.com>; Anna Schumaker
>>>>> <Anna.Schumaker@Netapp.com>; linux-nfs@vger.kernel.org
>>>>> Cc: netdev@vger.kernel.org; Trond Myklebust
>>> <Trond.Myklebust@netapp.com>
>>>>> Subject: nfs NULL-dereferencing in net-next
>>>>>
>>>>> Hi!
>>>>>
>>>>> I'm hitting this reliably on net-next, HEAD at 3f3177bb680f
>>>>> ("fsl/fman: fix error return code in mac_probe()").
>>>>
>>>>
>>>> I see the same thing. It happens constantly on some of my machines, making
>>> them
>>>> completely unusable.
>>>>
>>>> I bisected it and got to the commit:
>>>>
>>>> commit 04ea1b3e6d8ed4978bb608c1748530af3de8c274
>>>> Author: Andy Adamson <andros@netapp.com>
>>>> Date: Fri Sep 9 09:22:27 2016 -0400
>>>>
>>>> NFS add xprt switch addrs test to match client
>>>>
>>>> Signed-off-by: Andy Adamson <andros@netapp.com>
>>>> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
>>>
>>> Thanks for reporting on this everyone! Does this patch help?
>>
>> Actually, I still see the same bug with the same trace.
Well, it was worth a shot. I'll keep poking at it.
>
> I rebuild the latest net-next and I'm not seeing the trace any more...
> I'm only seeing this (with or without your patch):
>
> [ 23.465877] NFS: set_pnfs_layoutdriver: cl_exchange_flags 0x0
> [ 23.473784] NFS: set_pnfs_layoutdriver: cl_exchange_flags 0x0
> [ 23.588890] NFS: set_pnfs_layoutdriver: cl_exchange_flags 0x0
> [ 23.596746] NFS: set_pnfs_layoutdriver: cl_exchange_flags 0x0
> [ 23.781574] NFS: set_pnfs_layoutdriver: cl_exchange_flags 0x0
> [ 23.789599] NFS: set_pnfs_layoutdriver: cl_exchange_flags 0x0
Interesting, I get that too when I try to use NFS v4.1. It's weird that the crash would stop happening like that, so maybe something is racy in this area.
Thanks for testing, Yotam and Jakub!
Anna
>
> HTH
>
next prev parent reply other threads:[~2016-10-26 18:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161017201943.64529739@jkicinski-Precision-T1700>
2016-10-25 17:19 ` nfs NULL-dereferencing in net-next Yotam Gigi
2016-10-26 14:40 ` Anna Schumaker
[not found] ` <DB3PR05MB0764B39F6EDF851A8A52EBACACAB0@DB3PR05MB0764.eurprd05.prod.outlook.com>
2016-10-26 18:08 ` Jakub Kicinski
2016-10-26 18:17 ` Anna Schumaker [this message]
2016-10-27 6:50 ` Yotam Gigi
2016-10-31 15:25 ` Jakub Kicinski
2016-11-03 13:06 ` Anna Schumaker
2016-11-10 14:47 ` Olaf Hering
2016-11-10 15:02 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ab5021c-84eb-cb9f-c7f5-4d856fdb0f4b@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=andros@netapp.com \
--cc=kubakici@wp.pl \
--cc=linux-nfs@vger.kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yotam.gi@gmail.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).