From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27775C4320A for ; Fri, 20 Aug 2021 15:52:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1012161152 for ; Fri, 20 Aug 2021 15:52:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241120AbhHTPxC (ORCPT ); Fri, 20 Aug 2021 11:53:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57481 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238278AbhHTPxB (ORCPT ); Fri, 20 Aug 2021 11:53:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629474743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JlZGKQdLiYduLYkrU1ycwzHzZ/QPrtvBjhejt7xEWxE=; b=FD3IUmW5wOeh1WiNCZUeNRs/ar0AKJk4PisJqED4PayKk2+NPomEd3baDFrDyrpWBz7MDq w35zrGxiHyvFihX5eh4RSrxkRkxPf9uKEwSFJDIxyabbXUM98f2uMQOu/obIVHcdE2fpM5 qls5iIoTf+4jrzoonAVjSLjfKOUKkoc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-_NWq6JctMRe4oFqtvaHFeA-1; Fri, 20 Aug 2021 11:52:22 -0400 X-MC-Unique: _NWq6JctMRe4oFqtvaHFeA-1 Received: by mail-wm1-f69.google.com with SMTP id r4-20020a1c4404000000b002e728beb9fbso758314wma.9 for ; Fri, 20 Aug 2021 08:52:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=JlZGKQdLiYduLYkrU1ycwzHzZ/QPrtvBjhejt7xEWxE=; b=mDkXtyFnnSc2XFty7zXtzRnybVnwALyHEEhnf3d0cVBZ1DAf2qnTL9rz+UPe9nzteF ceZeh69lqvZpqxOdM4Vkovj5WN5ZV1V6Umi+XBR1I3PqI/3sv/i8vgV5RWJT5Rm1UCt8 0eIszRacLTeodXsTMN5JLkoP4It8g62h7txH/+3LB1a1D7/ga50Khp4pUXTzxDUydiBB NRV9/yhT8/FOr8roKPimN2IUO4HeNgo9w7Rx8wbnd/i/gs3P6O3UrVar7i70PLCdWBHv ZE+C7qpjTPgbUKWjdMlFl5MX11XGAI7Z0jXffWiQFBjRNj+fi8+Jya8U2IaUNY5MLnhJ nTWA== X-Gm-Message-State: AOAM530AoDT9QVZVU3GL4ncPEwbmMFSvM3ozaghaE/UP40Sy7vUtBDp2 akO7mG+pmKYrgJYzbMpcvavxi1gLYBzuE5R4oV+nIZPB5+TY8dJTW15g71UBozUzWyx/E7iJ/pQ T5ZUXoiqt24QubyxWWY81 X-Received: by 2002:a7b:c112:: with SMTP id w18mr4714035wmi.60.1629474741074; Fri, 20 Aug 2021 08:52:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaJBeCrGw4MnIfr+I5SADEkPPbDd6DJwmXEz/DXBgKbV1Dt/yBLdB7ItdMspgW4ZXDhi9QGA== X-Received: by 2002:a7b:c112:: with SMTP id w18mr4714020wmi.60.1629474740919; Fri, 20 Aug 2021 08:52:20 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id a18sm10107804wmg.43.2021.08.20.08.52.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 08:52:20 -0700 (PDT) Subject: Re: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks To: Jeff Layton , torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ebiederm@xmission.com, willy@infradead.org, linux-nfs@vger.kernel.org, viro@zeniv.linux.org.uk, linux-doc@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, akpm@linux-foundation.org, luto@kernel.org, bfields@fieldses.org, w@1wt.eu, rostedt@goodmis.org, stable@vger.kernel.org References: <20210820135707.171001-1-jlayton@kernel.org> <20210820135707.171001-2-jlayton@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <0f4f3e65-1d2d-e512-2a6f-d7d63effc479@redhat.com> Date: Fri, 20 Aug 2021 17:52:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210820135707.171001-2-jlayton@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 20.08.21 15:57, Jeff Layton wrote: > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros > have disabled it. Warn the stragglers that still use "-o mand" that > we'll be dropping support for that mount option. > > Cc: stable@vger.kernel.org > Signed-off-by: Jeff Layton > --- > fs/namespace.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/fs/namespace.c b/fs/namespace.c > index ab4174a3c802..ffab0bb1e649 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void) > } > > #ifdef CONFIG_MANDATORY_FILE_LOCKING > +static bool warned_mand; > static inline bool may_mandlock(void) > { > + if (!warned_mand) { > + warned_mand = true; > + pr_warn("======================================================\n"); > + pr_warn("WARNING: the mand mount option is being deprecated and\n"); > + pr_warn(" will be removed in v5.15!\n"); > + pr_warn("======================================================\n"); > + } Is there a reason not to use pr_warn_once() ? -- Thanks, David / dhildenb