From: Steve Dickson <SteveD@RedHat.com>
To: NeilBrown <neilb@suse.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH nfs-utils] nfsidmap: honour --with-pluginpath for instalation.
Date: Mon, 10 Dec 2018 16:25:50 -0500 [thread overview]
Message-ID: <102d7214-4374-97a8-dde7-8be68fd81555@RedHat.com> (raw)
In-Reply-To: <87y3966s24.fsf@notabene.neil.brown.name>
On 12/3/18 7:42 PM, NeilBrown wrote:
>
> The path set with --with-pluginpath is not currently
> used when installing plugins. It should be.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
Committed...
steved.
> ---
> configure.ac | 1 +
> support/nfsidmap/Makefile.am | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4163f6a518f5..4bf5aea4442f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -450,6 +450,7 @@ if test -n "$path_plugins" ; then
> [Define this to change the plugins path])
> fi
> AM_CONDITIONAL(PATH_PLUGINS, test -n "$path_plugins")
> +AC_SUBST(PATH_PLUGINS, "$path_plugins")
>
> AC_SUBST(AM_CPPFLAGS, "$AM_CPPFLAGS")
> AC_DEFINE([HAVE_NFS4_SET_DEBUG], 1,
> diff --git a/support/nfsidmap/Makefile.am b/support/nfsidmap/Makefile.am
> index 8b5dfe4e784a..cdbeb4c1a9ac 100644
> --- a/support/nfsidmap/Makefile.am
> +++ b/support/nfsidmap/Makefile.am
> @@ -1,4 +1,4 @@
> -pkgplugindir=$(libdir)/libnfsidmap
> +pkgplugindir=$(PATH_PLUGINS)
>
> if ENABLE_LDAP
> UMICH_LDAP_LIB = umich_ldap.la
>
prev parent reply other threads:[~2018-12-10 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 0:42 [PATCH nfs-utils] nfsidmap: honour --with-pluginpath for instalation NeilBrown
2018-12-10 21:25 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=102d7214-4374-97a8-dde7-8be68fd81555@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox