linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Vanns <james.vanns@framestore.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: Where in the server code is fsinfo rtpref calculated?
Date: Wed, 15 May 2013 14:42:42 +0100 (BST)	[thread overview]
Message-ID: <1045951723.19965005.1368625362930.JavaMail.root@framestore.com> (raw)
In-Reply-To: <20130514220122.GE16811@fieldses.org>

> fs/nfsd/nfssvc.c:nfsd_get_default_maxblksize() is probably a good
> starting point.  Its caller, nfsd_create_serv(), calls
> svc_create_pooled() with the result that's calculated.

Hmm. If I've read this section of code correctly, it seems to me
that on most modern NFS servers (using TCP as the transport) the default
and preferred blocksize negotiated with clients will almost always be
1MB - the maximum RPC payload. The nfsd_get_default_maxblksize() function
seems obsolete for modern 64-bit servers with at least 4G of RAM as it'll
always prefer this upper bound instead of any value calculated according to
available RAM.

For what it's worth (not sure if I specified this) I'm running kernel 2.6.32.

Anyway, this file/function appears to set the default *max* blocksize. I haven't 
read all the related code yet, but does the preferred block size derive 
from this maximum too?

Thanks,

Jim

> For fsinfo see fs/nfsd/nfs3proc.c:nfsd3_proc_fsinfo, which uses
> svc_max_payload().
> 
> --b.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Jim Vanns
Senior Software Developer
Framestore

  parent reply	other threads:[~2013-05-15 13:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 11:17 Where in the server code is fsinfo rtpref calculated? James Vanns
2013-05-14 22:01 ` J. Bruce Fields
2013-05-15  9:21   ` James Vanns
2013-05-15 13:42   ` James Vanns [this message]
2013-05-15 14:15     ` J. Bruce Fields
2013-05-15 14:34       ` James Vanns
2013-05-15 14:47         ` J. Bruce Fields
2013-05-15 15:20           ` Myklebust, Trond
2013-05-15 16:32           ` James Vanns
2013-05-15 17:42             ` J. Bruce Fields
2013-05-17 11:43               ` James Vanns
2013-05-17 13:56                 ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1045951723.19965005.1368625362930.JavaMail.root@framestore.com \
    --to=james.vanns@framestore.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).