From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A8DEC77B61 for ; Thu, 13 Apr 2023 13:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbjDMN4b (ORCPT ); Thu, 13 Apr 2023 09:56:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjDMN4a (ORCPT ); Thu, 13 Apr 2023 09:56:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B86AF2715 for ; Thu, 13 Apr 2023 06:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681394142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zAyG0A+b0GuohSioj1G+MKBql7l3GfquTjJB8uXanBs=; b=BP04ya4TQdyquyWoyAnEWJNsoVRcjkVQkEQ9moxvJFn6Lfbfh2O3kXyACniaZsb9ulXWnm n/wHOsD+8LjggUUQxIqqM/mRAGYMuQhEVReG6DymHsbs4Ju4KLl4LSlIhE6svPpH5tTBu4 ARymyKMnIy5ma/Iw99fw26xQfeKKVmY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-440-M36pobzLNHyM6JvGzIpeWQ-1; Thu, 13 Apr 2023 09:55:40 -0400 X-MC-Unique: M36pobzLNHyM6JvGzIpeWQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0645D1C04321; Thu, 13 Apr 2023 13:55:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18A90112132E; Thu, 13 Apr 2023 13:55:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com> References: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com> <380323.1681314997@warthog.procyon.org.uk> To: Chuck Lever III Cc: dhowells@redhat.com, Herbert Xu , Scott Mayhew , Ard Biesheuvel , Jeff Layton , Linux NFS Mailing List , "linux-crypto@vger.kernel.org" Subject: Re: Did the in-kernel Camellia or CMAC crypto implementation break? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1078649.1681394138.1@warthog.procyon.org.uk> Date: Thu, 13 Apr 2023 14:55:38 +0100 Message-ID: <1078650.1681394138@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Chuck Lever III wrote: > Ah, I see Scott is Cc'd. Yes, Scott reported this to me yesterday. Found it (see patch sent separately). There was an uninitialised variable in sunrpc. The krb5lib problem was that I'd lost the byteswapping of the usage value in the test data when I split it out of the net/rxrpc/ directory, e.g.: @@ -167,7 +167,7 @@ const struct krb5_enc_test krb5_enc_tests[] = { .plain = "'1", .conf = "6F2FC3C2A166FD8898967A83DE9596D9", .K0 = "5027BC231D0F3A9D23333F1CA6FDBE7C", - .usage = 1, + .usage = htonl(1), .ct = "842D21FD950311C0DD464A3F4BE8D6DA88A56D559C9B47D3F9A85067AF661559B8", }, { .krb5 = &krb5_camellia128_cts_cmac, David