From: Tom Tucker <tom@opengridcomputing.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nfs@lists.sourceforge.net
Subject: Re: [RFC, PATCH 06/20] svc: export svc_sock_enqueue, svc_sock_received
Date: Tue, 10 Jul 2007 19:45:03 -0500 [thread overview]
Message-ID: <1184114703.30033.89.camel@trinity.ogc.int> (raw)
In-Reply-To: <1184108889.6480.35.camel@heimdal.trondhjem.org>
See below....
On Tue, 2007-07-10 at 19:08 -0400, Trond Myklebust wrote:
> On Tue, 2007-07-10 at 00:34 -0500, Tom Tucker wrote:
> > Export svc_sock_enqueue() and svc_sock_received() so they
> > can be used by sunrpc server transport implementations
> > (even future modular ones).
> >
> > Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>
> > Signed-off-by: Peter Leckie <pleckie@melbourne.sgi.com>
> > Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
> > ---
> >
> > include/linux/sunrpc/svcsock.h | 2 ++
> > net/sunrpc/svcsock.c | 7 ++++---
> > 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/sunrpc/svcsock.h b/include/linux/sunrpc/svcsock.h
> > index ce93b10..9fa4321 100644
> > --- a/include/linux/sunrpc/svcsock.h
> > +++ b/include/linux/sunrpc/svcsock.h
> > @@ -108,6 +108,8 @@ int svc_addsock(struct svc_serv *serv,
> > int fd,
> > char *name_return,
> > int *proto);
> > +void svc_sock_enqueue(struct svc_sock *svsk);
> > +void svc_sock_received(struct svc_sock *svsk);
> >
> > /*
> > * svc_makesock socket characteristics
> > diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> > index 1a6a933..f09c4b4 100644
> > --- a/net/sunrpc/svcsock.c
> > +++ b/net/sunrpc/svcsock.c
> > @@ -209,7 +209,7 @@ svc_release_skb(struct svc_rqst *rqstp)
> > * processes, wake 'em up.
> > *
> > */
> > -static void
> > +void
> > svc_sock_enqueue(struct svc_sock *svsk)
> > {
> > struct svc_serv *serv = svsk->sk_server;
> > @@ -287,6 +287,7 @@ svc_sock_enqueue(struct svc_sock *svsk)
> > out_unlock:
> > spin_unlock_bh(&pool->sp_lock);
> > }
> > +EXPORT_SYMBOL(svc_sock_enqueue);
>
> EXPORT_SYMBOL_GPL(), please. This is definitely not something we want to
> encourage out-of-tree modules to use.
Ok, done. Note that svc_sock_names is currently EXPORT_SYMBOL.
>
> >
> > /*
> > * Dequeue the first socket. Must be called with the pool->sp_lock held.
> > @@ -315,14 +316,14 @@ svc_sock_dequeue(struct svc_pool *pool)
> > * Note: SK_DATA only gets cleared when a read-attempt finds
> > * no (or insufficient) data.
> > */
> > -static inline void
> > +void
> > svc_sock_received(struct svc_sock *svsk)
> > {
> > svsk->sk_pool = NULL;
> > clear_bit(SK_BUSY, &svsk->sk_flags);
> > svc_sock_enqueue(svsk);
> > }
> > -
> > +EXPORT_SYMBOL(svc_sock_received);
>
> ditto...
Done.
> >
> > /**
> > * svc_reserve - change the space reserved for the reply to a request.
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > NFS maillist - NFS@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/nfs
>
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-07-11 0:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 5:27 [RFC,PATCH 00/20] svc: sunrpc server side transport switch Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 01/20] svc: Add svc_sock_ops Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 02/20] svc: sko_detach and sko_free Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 03/20] svc: svc_prep_reply_hdr Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 04/20] svc: sko_has_wspace Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 05/20] svc: svc_max_payload Tom Tucker
2007-07-10 5:34 ` [RFC, PATCH 06/20] svc: export svc_sock_enqueue, svc_sock_received Tom Tucker
2007-07-10 23:08 ` Trond Myklebust
2007-07-11 0:45 ` Tom Tucker [this message]
2007-07-10 5:34 ` [RFC,PATCH 07/20] svc: centralise close handling Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 08/20] svc: centralise accept handling Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 09/20] svc: Add SK_LISTENER sock flag Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 10/20] svc: Add generic refcount services Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 11/20] svc: cleanup svc_sock initialization Tom Tucker
2007-07-10 5:34 ` [RFC, PATCH 12/20] scv: Create transport neutral debug bit RPCDBG_SVCTRANS Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 13/20] svc: Add svc_[un]register_transport Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 14/20] svc: Register TCP/UDP Transports Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 15/20] svc: transport file implementation Tom Tucker
2007-07-10 23:30 ` Trond Myklebust
2007-07-10 5:34 ` [RFC,PATCH 16/20] svc: sko_create_svc Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 17/20] svc: Add sko_get_name service Tom Tucker
2007-07-10 5:34 ` [RFC,PATCH 18/20] svc: Add sko_defer routine Tom Tucker
2007-07-10 5:35 ` [RFC,PATCH 19/20] knfsd: call svc_create_svcsock Tom Tucker
2007-07-10 23:32 ` Trond Myklebust
2007-07-11 0:48 ` Tom Tucker
2007-07-11 0:59 ` Tom Tucker
2007-07-10 5:35 ` [RFC,PATCH 20/20] knfsd: create listener via portlist write Tom Tucker
2007-07-10 23:36 ` [RFC, PATCH " Trond Myklebust
2007-07-11 1:04 ` Tom Tucker
-- strict thread matches above, loose matches on Subject: below --
2007-08-20 16:20 [RFC,PATCH 00/20] svc: Server Side Transport Switch Tom Tucker
2007-08-20 16:23 ` [RFC, PATCH 06/20] svc: export svc_sock_enqueue, svc_sock_received Tom Tucker
2007-08-21 16:03 ` Chuck Lever
2007-08-21 18:08 ` Tom Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184114703.30033.89.camel@trinity.ogc.int \
--to=tom@opengridcomputing.com \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox