From: Eric Paris <eparis@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
hch@infradead.org, linux-nfs@vger.kernel.org,
selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org,
steved@redhat.com, jlayton@redhat.com, jmorris@namei.org,
casey@schaufler-ca.com, trond.myklebust@fys.uio.no,
chuck.lever@oracle.com, linux-fsdevel@vger.kernel.org
Subject: Re: NFS/LSM: allow NFS to control all of its own mount options
Date: Wed, 20 Feb 2008 08:56:58 -0500 [thread overview]
Message-ID: <1203515818.2928.138.camel@localhost.localdomain> (raw)
In-Reply-To: <1203515410.9902.128.camel-/ugcdrsPCSfIm9DtXLC9OUVfdvkotuLY+aIohriVLy8@public.gmane.org>
On Wed, 2008-02-20 at 08:50 -0500, Stephen Smalley wrote:
> On Wed, 2008-02-20 at 11:08 +0100, Miklos Szeredi wrote:
> > > Please don't introduce a special case for just nfs. All filesystems
> > > should control their mount options, so please provide some library
> > > helpers for context= handling and move it into all filesystems that
> > > can support selinux.
> >
> > Hmm, looks like selinux is not showing it's mount options in
> > /proc/mounts. Well, actually there's no infrastructure for it either.
> > Here's a template patch (completely untested).
>
> I think the intent is to use the security_sb_get_mnt_opts() hook for
> this purpose.
It was. I already knew about this issue and its 'on my list.' Although
I guess we need a something ?new LSM hook? which will translate the
sb_get_mnt_opts stuff into a single text string. Or I guess really that
can be done in you sb_show_options and I can just use sb_get_mnt_opts
under the covers. Anyway, unrelated issue that will get fixed as soon
as this real BUG() is fixed.
-Eric
prev parent reply other threads:[~2008-02-20 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 21:38 NFS/LSM: allow NFS to control all of its own mount options Eric Paris
[not found] ` <1203457094.2928.113.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-19 22:24 ` Christoph Hellwig
2008-02-19 22:36 ` Eric Paris
2008-02-19 23:18 ` Casey Schaufler
2008-02-20 0:25 ` James Morris
2008-02-20 13:48 ` Stephen Smalley
2008-02-20 10:08 ` Miklos Szeredi
2008-02-20 13:50 ` Stephen Smalley
[not found] ` <1203515410.9902.128.camel-/ugcdrsPCSfIm9DtXLC9OUVfdvkotuLY+aIohriVLy8@public.gmane.org>
2008-02-20 13:56 ` Eric Paris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203515818.2928.138.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=chuck.lever@oracle.com \
--cc=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=steved@redhat.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox