From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Ensure that 'noac' and/or 'actimeo=0' turn off attribute caching
Date: Mon, 05 May 2008 11:59:43 -0400 [thread overview]
Message-ID: <1210003183.7409.5.camel@localhost> (raw)
In-Reply-To: <95989F05-2BCE-4923-94C6-46D46270D120@oracle.com>
On Mon, 2008-05-05 at 11:55 -0400, Chuck Lever wrote:
> nfs_update_inode() is the only other place that actually uses the
> value of nfsi->attrtimeo (and it uses it with time_in_range). I'm
> merely asking if we have verified that the behavior is correct if
> nfsi-
> >attrtimeo == 0.
>
> The logic there is abstruse, so it's difficult to tell if the (nfsi-
> >attrtimeo == 0) case is behaving as expected. I don't see any
> obvious problem with it right now.
That part of the code is irrelevant as far as actimeo=0/noac is
concerned. It is the mechanism that decides whether or not to double the
existing value of nfsi->attrtimeo for the case where the file/directory
hasn't changed in a while.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
prev parent reply other threads:[~2008-05-05 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 20:25 [PATCH] NFS: Ensure that 'noac' and/or 'actimeo=0' turn off attribute caching Trond Myklebust
[not found] ` <20080502202502.29449.81285.stgit-KPEdlmqt5P7XOazzY/2fV4TcuzvYVacciM950cveMlzk1uMJSBkQmQ@public.gmane.org>
2008-05-05 15:02 ` Chuck Lever
2008-05-05 15:23 ` Trond Myklebust
2008-05-05 15:55 ` Chuck Lever
2008-05-05 15:59 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210003183.7409.5.camel@localhost \
--to=trond.myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox