Linux NFS development
 help / color / mirror / Atom feed
From: Tom Tucker <tom@opengridcomputing.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: linux-nfs <linux-nfs@vger.kernel.org>
Subject: [PATCH] svcrdma: Initialize the context free list for listeners
Date: Fri, 23 May 2008 10:32:59 -0500	[thread overview]
Message-ID: <1211556779.4114.17.camel@trinity.ogc.int> (raw)

Move the initialization of the sc_ctxt_free list to the
client/listener generic bit of the init logic. This is
necessary to avoid a bug check when shutting down a listening
endpoint when list debug is enabled. This bug was introduced
when the context cache was converted to use Linux lists.

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
---
 net/sunrpc/xprtrdma/svc_rdma_transport.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index 54b2126..2c2f5f6 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -446,7 +446,6 @@ static void create_context_cache(struct svcxprt_rdma *xprt,
 	xprt->sc_ctxt_cnt = 0;
 	atomic_set(&xprt->sc_ctxt_used, 0);
 
-	INIT_LIST_HEAD(&xprt->sc_ctxt_free);
 	for (i = 0; i < ctxt_count; i++) {
 		ctxt = kmalloc(sizeof(*ctxt), GFP_KERNEL);
 		if (ctxt) {
@@ -496,6 +495,7 @@ static struct svcxprt_rdma *rdma_create_xprt(struct svc_serv *serv,
 	atomic_set(&cma_xprt->sc_sq_count, 0);
 	atomic_set(&cma_xprt->sc_ctxt_used, 0);
 
+	INIT_LIST_HEAD(&cma_xprt->sc_ctxt_free);
 	if (!listener) {
 		int reqs = cma_xprt->sc_max_requests;
 		create_context_cache(cma_xprt,


             reply	other threads:[~2008-05-23 15:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23 15:32 Tom Tucker [this message]
     [not found] ` <1211556779.4114.17.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2008-05-25 19:03   ` [PATCH] svcrdma: Initialize the context free list for listeners J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211556779.4114.17.camel@trinity.ogc.int \
    --to=tom@opengridcomputing.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox