Linux NFS development
 help / color / mirror / Atom feed
From: Timo Sirainen <tss@iki.fi>
To: Peter Staubach <staubach@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: inode caching
Date: Tue, 27 May 2008 18:40:48 +0300	[thread overview]
Message-ID: <1211902848.3904.279.camel@hurina> (raw)
In-Reply-To: <483C031B.80601@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 3078 bytes --]

On Tue, 2008-05-27 at 08:48 -0400, Peter Staubach wrote:
> Timo Sirainen wrote:
> > NFS server: Linux 2.6.25
> > NFS client: Linux debian 2.6.25-2 (or 2.6.23.1)
> >
> > If I do:
> >
> > NFS client: fd1 = creat("foo"); write(fd1, "xx", 2); fsync(fd1);
> > NFS server: unlink("foo"); creat("foo");
> > NFS client: fd2 = open("foo"); fstat(fd1, &st1); fstat(fd2, &st2);
> > fstat(fd1, &st3);
> >
> > The result is usually that the fstat(fd1) fails with ESTALE. But
> > sometimes the result is st1.st_ino == st2.st_ino == st3.st_ino and
> > st1.st_size == 2 but st2.st_size == 0. So I see two different files
> > using the same inode number. I'd really want to avoid seeing that
> > condition.
> >
> >   
> 
> This is really up the file system on the server. It is the one
> that selects the inode number when creating a new file.

I don't mind that the inode gets reused, I mind that I can't reliably
detect that situation.

> > So what I'd want to know is:
> >
> > a) Why does this happen only sometimes? I can't really figure out from
> > the code what invalidates the fd1 inode. Apparently the second open()
> > somehow, but since it uses the new "foo" file with a different struct
> > inode, where does the old struct inode get invalidated?
> >
> >   
> 
> This will happen always, but you may see occasional successful
> fstat() calls on the client due to attribute caching and/or
> dentry caching.

I would understand if it always failed or always succeeded, but it seems
to be somewhat random now. And it's not "occational successful fstat()",
but it's "occational failed fstat()". The difference shouldn't be
because of attribute caching, because I specify it explicitly to two
seconds and run the test within that 2 second. So the test should always
hit the attribute cache, and according to you that should always cause
it to succeed (but it rarely does). I think dentry caching also more or
less depends on attribute cache timeout?

> > b) Can this be fixed? Or is it just luck that it works as well as it
> > does now?
> >
> >   
> 
> This can be fixed, somewhat. I have some changes to address the
> ESTALE situation in system calls that take filename as arguments,
> but I need to work with some more people to get them included.
> The system calls which do not take file names as arguments can not
> be recovered from because the file they are referring is really
> gone or at least not accessible anymore.
> 
> The reuse of the inode number is just a fact of life and that way
> that file systems work. I would suggest rethinking your application
> in order to reduce or eliminate any dependence that it might have.

The problem I have is that I need to reliably find out if a file has
been replaced with a new file. So I first flush the dentry cache
(chowning parent directory), stat() the file and fstat() the opened
file. If fstat() fails with ESTALE or if the inodes don't match, I know
that the file has been replaced and I need to re-open and re-read it.
This seems to work nearly always.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2008-05-27 15:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-26 20:58 inode caching Timo Sirainen
2008-05-27 12:48 ` Peter Staubach
2008-05-27 15:40   ` Timo Sirainen [this message]
2008-05-27 18:09     ` Peter Staubach
2008-05-27 19:13       ` Timo Sirainen
2008-05-28  5:38         ` Benny Halevy
2008-05-28 13:59           ` J. Bruce Fields
2008-05-28 15:20             ` Timo Sirainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211902848.3904.279.camel@hurina \
    --to=tss@iki.fi \
    --cc=linux-nfs@vger.kernel.org \
    --cc=staubach@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox