Re: [PATCH 3/4] NFS: Add string length argument to nfs_parse_server_address

[Trond Myklebust <Trond.Myklebust@netapp.com>]

On Wed, 2008-06-18 at 18:32 -0400, Chuck Lever wrote:
> To make nfs_parse_server_address() more generally useful, allow it to
> accept input strings that are not terminated with '\0'.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
>  fs/nfs/super.c |  107 ++++++++++++++++++++++++++++++++++++++++----------------
>  1 files changed, 77 insertions(+), 30 deletions(-)
> 
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index 98c8110..818bc1b 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -62,6 +62,13 @@
>  
>  #define NFSDBG_FACILITY		NFSDBG_VFS
>  
> +#ifndef INET_ADDRSTRLEN
> +#define INET_ADDRSTRLEN		(16)
> +#endif
> +#ifndef INET6_ADDRSTRLEN
> +#define INET6_ADDRSTRLEN	(48)
> +#endif
> +

If you're resending, then can you please get rid of the above #ifndefs?
If somebody else is defining an INET_ADDRSTRLEN that overrides ours,
then I definitely want to know about it at compile time, so that I can
check for correctness.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com