From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B2DB18756A for ; Mon, 20 Jan 2025 20:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737404309; cv=none; b=GppAZhI/TNue+C3Eqzjndttb3/iwri59XT63zQg7g7dpcjhiGCGCdr9rH/zZ/78oj9Nff+py5L8rOWnMAlFZwuWjtRGDUKBDPM2JzyG9fI7XYKN3c2bNjeFN122kjWgdNXLz1ddcai8g6jyzgbcg9qb0eSkxaqH7n6xiAdF/32I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737404309; c=relaxed/simple; bh=Kz2TlXXwQ+SzvxVI4EEYgGPZIS5aE1/jeFB9dM77uSI=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=CeysIUUhW/Nm9J07f4BqY4hE1oa50qLrzz9jwV2EVIr4tkgJzD8zLaZo4A/q6JMi5xUlH+bZrOmAEX6xRjxfQZ3BdnI6YUhvewx0wVCe5PQzWPi18H0kcDaF9bbq6kyGRKPd1wHCv2hex/wDeqlU4aKEGS8+PNHNA38Nphif5X8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=V/jYadSI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V/jYadSI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737404307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1b+YsBqSK8VeGuQPF+mRZwuPBiG3uaSaaur3ZRV5/uk=; b=V/jYadSIfT+fsAf3u1zfj7s5y4y+FtJNyD8DQFCRcAlAxH8DMz6FwD7/FFoxieYdyuxzvo 1l00Z8kzjAFqdZFYEjin+SJq5PXNvhQx968rsNbWKPu8OS2XJkBDpuzgZ5GnlJdt0HFleN 6TXoHbnIjuHJUJs48f07UiKoRW02tx4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-jn_OIywHOwaitWAB_dzWrQ-1; Mon, 20 Jan 2025 15:18:24 -0500 X-MC-Unique: jn_OIywHOwaitWAB_dzWrQ-1 X-Mimecast-MFC-AGG-ID: jn_OIywHOwaitWAB_dzWrQ Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 78F041956080; Mon, 20 Jan 2025 20:18:19 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2BC1019560A3; Mon, 20 Jan 2025 20:18:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20250120191250.GA39025@sol.localdomain> References: <20250120191250.GA39025@sol.localdomain> <20250120173937.GA2268@sol.localdomain> <20250120135754.GX6206@kernel.org> <20250117183538.881618-1-dhowells@redhat.com> <20250117183538.881618-4-dhowells@redhat.com> <1201143.1737383111@warthog.procyon.org.uk> <1212970.1737399580@warthog.procyon.org.uk> To: Eric Biggers Cc: dhowells@redhat.com, Simon Horman , Herbert Xu , Chuck Lever , Trond Myklebust , "David S. Miller" , Marc Dionne , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ard Biesheuvel , linux-crypto@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 03/24] crypto: Add 'krb5enc' hash and cipher AEAD algorithm Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1215833.1737404294.1@warthog.procyon.org.uk> Date: Mon, 20 Jan 2025 20:18:14 +0000 Message-ID: <1215834.1737404294@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Eric Biggers wrote: > In any case, why would you need anything to do asynchronous at all here? Because authenc, which I copied, passes the asynchronocity mode onto the two algos it runs (one encrypt, one hash). If authenc is run synchronously, then the algos are run synchronously and serially; but if authenc is run async, then the algos are run asynchronously - but they may still have to be run serially[*] and the second is dispatched from the completion handler of the first. So two different paths through the code exist, and rxgk and testmgr only test the synchronous path. [*] Because in authenc-compatible encoding types, the output of the encryption is hashed. Older krb5 encodings hash the plaintext and the hash generation and the encrypt can be run in parallel. For decrypting, the reverse is true; authenc may be able to do the decrypt and the hash in parallel... But parallellisation also requires that the input and output buffers are not the same. Anyway. If it can be done asynchronously, that should probably be tested. David