From: David Howells <dhowells@redhat.com>
To: David Wysochanski <dwysocha@redhat.com>
Cc: dhowells@redhat.com, Dan Carpenter <dan.carpenter@oracle.com>,
linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [bug report] nfs: Convert to new fscache volume/cookie API
Date: Mon, 06 Dec 2021 09:28:35 +0000 [thread overview]
Message-ID: <1218010.1638782915@warthog.procyon.org.uk> (raw)
In-Reply-To: <CALF+zO=+1JV2JbXWL1zFjkWX=Rz-q93X0C7GTvng77U4LqT91w@mail.gmail.com>
David Wysochanski <dwysocha@redhat.com> wrote:
> 1. Use the nfs_server.s_dev (someone can lookup the mount from
> /proc/self/mountinfo)
> Maybe "%u:%u", MAJOR(sb->s_dev), MINOR(sb->s_dev)
I think those numbers are just allocated on the fly, so they're not
consistent, so just unmounting and remounting can change them.
> 2. Use a checksum on the parameters?
I have considered hashing them. It might also make sense to only include them
if they get explicitly set.
David
prev parent reply other threads:[~2021-12-06 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 8:54 [bug report] nfs: Convert to new fscache volume/cookie API Dan Carpenter
2021-12-03 13:39 ` David Wysochanski
2021-12-03 16:06 ` David Howells
2021-12-03 20:05 ` David Wysochanski
2021-12-06 9:28 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218010.1638782915@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=dwysocha@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox