From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/7] NLM: Convert nlm_lookup_host() to use a single argument
Date: Fri, 03 Oct 2008 13:39:40 -0400 [thread overview]
Message-ID: <1223055580.8111.1.camel@localhost> (raw)
In-Reply-To: <51B54FBE-A322-4561-BCEC-AB805DE3BB06@oracle.com>
On Fri, 2008-10-03 at 13:33 -0400, Chuck Lever wrote:
> >> +#define NLM_SERVER (0)
> >> +#define NLM_CLIENT (1)
> >> +
> >
> > Could we please get RID of this crap instead of 'documenting' it?
> > There
> > is absolutely _no_ excuse for keeping a single list for both server
> > and
> > client struct hosts...
> >
> > Strongly NACKED....
>
> We haven't dropped that work item, but Bruce and I agreed months ago
> that he would handle the client/server list split *after* I had
> finished the IPv6 changes. I think the IPv6 work is a much higher
> priority here.
Then please don't throw in unnecessary trivia that can confuse people.
next prev parent reply other threads:[~2008-10-03 17:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 16:49 [PATCH 0/7] Replacements for last week's patches Chuck Lever
[not found] ` <20081003162856.10198.20451.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-10-03 16:50 ` [PATCH 1/7] NLM: Convert nlm_lookup_host() to use a single argument Chuck Lever
[not found] ` <20081003165006.10198.9012.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-10-03 17:16 ` Trond Myklebust
2008-10-03 17:33 ` Chuck Lever
2008-10-03 17:39 ` Trond Myklebust [this message]
2008-10-03 16:50 ` [PATCH 2/7] lockd: Support non-AF_INET addresses in nlm_lookup_host() Chuck Lever
2008-10-03 16:50 ` [PATCH 3/7] lockd: Adjust nlmclnt_lookup_host() signature to accomodate non-AF_INET Chuck Lever
2008-10-03 16:50 ` [PATCH 4/7] lockd: Adjust nlmsvc_lookup_host() to accomodate AF_INET6 addresses Chuck Lever
2008-10-03 16:50 ` [PATCH 5/7] lockd: change nlmclnt_grant() to take a "struct sockaddr *" Chuck Lever
2008-10-03 16:50 ` [PATCH 6/7] lockd: Add helper to sanity check incoming NOTIFY requests Chuck Lever
2008-10-03 16:50 ` [PATCH 7/7] lockd: Remove unused fields in the nlm_reboot structure Chuck Lever
2008-10-03 21:45 ` [PATCH 0/7] Replacements for last week's patches J. Bruce Fields
2008-10-03 21:48 ` J. Bruce Fields
2008-10-03 21:53 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223055580.8111.1.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox