Re: [GIT PULL -tip] fix 33 make headers_check warnings

Jaswinder Singh Rajput
2009-01-21T00:40:04Z

On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
> >>>
> >> That patch looks wrong, and unnecessary. It was fine before.
> > Nope - include/linux/dvb/audio.h failed to include linux/types.h
> > despite the fact that is uses __u32 etc.
> >
> > But why the _kernel_ should include a userspace header is
> > much more questionable.
> >
>
> <stdint.h> is one of a handful of headers provided by gcc itself.
>

Should I reintroduce my patch to solve this warning of 'make headers_check':
usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include <linux/types.h>

diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h
index 89412e1..758a48c 100644
--- a/include/linux/dvb/audio.h
+++ b/include/linux/dvb/audio.h
@@ -24,9 +24,8 @@
#ifndef _DVBAUDIO_H_
#define _DVBAUDIO_H_

-#ifdef __KERNEL__
#include <linux/types.h>
-#else
+#ifndef __KERNEL__
#include <stdint.h>
#endif

Or you guys have some better plan.

Thanks,

--
JSR