Re: [GIT PULL -tip] fix 33 make headers_check warnings

Stephen Rothwell
2009-01-19T00:24:39Z

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

On Sun, 18 Jan 2009 01:47:21 +0530 Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
>
> diff --git a/include/linux/nfsd/stats.h b/include/linux/nfsd/stats.h
> index 7678cfb..0b53cfe 100644
> --- a/include/linux/nfsd/stats.h
> +++ b/include/linux/nfsd/stats.h
> @@ -29,9 +29,11 @@ struct nfsd_stats {
> unsigned int ra_size; /* size of ra cache */
> unsigned int ra_depth[11]; /* number of times ra entry was found that deep
> * in the cache (10percentiles). [10] = not found */
> +#ifdef __KERNEL__
> #ifdef CONFIG_NFSD_V4
> unsigned int nfs4_opcount[LAST_NFS4_OP + 1]; /* count of individual nfsv4 operations */
> #endif
> +#endif /* __KERNEL__ */
>
> };

The only variable in the kernel of type "struct nfsd_stats" is only
exported to user mode via procfs, so this whole structure could probably
go inside __KERNEL__. Then looking harder, I wonder if this header
should be exported to user mode at all.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]