From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: Thoughts about cache consistency and directories in particular. Date: Fri, 20 Feb 2009 14:14:55 -0800 Message-ID: <1235168095.31066.27.camel@heimdal.trondhjem.org> References: <18846.4842.625445.980681@notabene.brown> <1235156207.31066.21.camel@heimdal.trondhjem.org> <18847.2578.480148.216735@notabene.brown> <1235161966.31066.24.camel@heimdal.trondhjem.org> <18847.6988.418374.839185@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain Cc: "J. Bruce Fields" , linux-nfs@vger.kernel.org To: Neil Brown Return-path: Received: from mail-out1.uio.no ([129.240.10.57]:42710 "EHLO mail-out1.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753772AbZBTWPT (ORCPT ); Fri, 20 Feb 2009 17:15:19 -0500 In-Reply-To: <18847.6988.418374.839185-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Sat, 2009-02-21 at 08:06 +1100, Neil Brown wrote: > On Friday February 20, trond.myklebust@fys.uio.no wrote: > > On Sat, 2009-02-21 at 06:52 +1100, Neil Brown wrote: > > > On Friday February 20, trond.myklebust@fys.uio.no wrote: > > > > It should work fine. The ctime tracks the mtime in all cases except when > > > > you setacl, setfattr, chown, chgrp, chmod, or touch the directory. Those > > > > should be very rare operations for pretty much any workload... > > > > > > > > > > Does that mean you'll take the patch ?? > > > > Not as it stands. You really want to be calling > > nfs_force_lookup_revalidate() instead of invalidating the directory > > contents. > > Surely it is 'aswell' rather than 'instead' ?? > I need > invalid |= NFS_INO_INVALID_DATA; > to flush the readdir cache, and > nfs_force_lookup_revalidate(inode) > to flush the lookup cache > ?? You're right. Sorry... Cheers Trond