From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68209C77B6E for ; Fri, 14 Apr 2023 10:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbjDNKSC (ORCPT ); Fri, 14 Apr 2023 06:18:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbjDNKSC (ORCPT ); Fri, 14 Apr 2023 06:18:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB2D0C9 for ; Fri, 14 Apr 2023 03:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681467437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HGlU0PvOV1zf33jFs6Isk0h8BFNeNak/ejipOrEy1sk=; b=YgV9rN1vqE+jRLymjhjFMf5830T/ys+0Ws9HfDirhCHgPffXhLuHp76R6JdGCcqSEXU1eC zX4a9CKQmKfVhrfmUxrwFiVIS1OyabxKt0G30OPAlks3wLH0rNPGXmpvZQnb34hZspJgXe /utL1TG1mVHnOHTJveEK5ZS1tlAsDcQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-n6LkH29JOM-7W2ZSpQRXPA-1; Fri, 14 Apr 2023 06:17:12 -0400 X-MC-Unique: n6LkH29JOM-7W2ZSpQRXPA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9011A811E7C; Fri, 14 Apr 2023 10:17:11 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7327492C14; Fri, 14 Apr 2023 10:17:10 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com> <380323.1681314997@warthog.procyon.org.uk> <1078650.1681394138@warthog.procyon.org.uk> <1235770.1681462057@warthog.procyon.org.uk> To: Herbert Xu Cc: dhowells@redhat.com, Chuck Lever III , Scott Mayhew , Ard Biesheuvel , Jeff Layton , Linux NFS Mailing List , "linux-crypto@vger.kernel.org" Subject: Re: Did the in-kernel Camellia or CMAC crypto implementation break? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1239034.1681467430.1@warthog.procyon.org.uk> Date: Fri, 14 Apr 2023 11:17:10 +0100 Message-ID: <1239035.1681467430@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Herbert Xu wrote: > > Actually, I was wondering about that. I see that all the testing data > > seems to be statically loaded in testmgr.[ch], even if the algorithms to > > be tested are resident in modules that aren't loaded yet (so it's kind of > > test "on demand"). I guess it can't be split up amongst the algorithm > > modules as some of the tests require stuff from multiple modules (eg. aes > > + cbs + cts). > > Yes I've been meaning to split this up so they're colocated with > the generic implementation. Might be easier if I wait to see how you do that. > Unless this code has at least two users it's probably not worth > it (but there are exceptions, e.g. we did a one-user algorithm > for dm-crypt). There would be just two users at the moment: sunrpc/nfs and rxrpc/afs. I don't know if cifs or ceph could make use of it. David