Re: [pnfs] [PATCH 13/29] nfsd41: free drc cache buffers

William A. (Andy) Adamson
2009-04-24T14:11:45Z

On Thu, Apr 23, 2009 at 7:39 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
> On Thu, Apr 23, 2009 at 12:42:52PM -0400, andros@netapp.com wrote:
>> From: Andy Adamson <andros@netapp.com>
>
> This should probably be folded into the last patch.
>
> (For one reason: looks like applying everything up to the last patch
> would result in a kernel that leaked memory, since these things never
> got freed? The rule here is that applying patches 1...n of any patch
> series should never introduce any new problems.)

OK

>
> --b.
>
>>
>> Signed-off-by: Andy Adamson <andros@netapp.com>
>> ---
>> fs/nfsd/nfs4state.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>> index 9e79e0c..787cffe 100644
>> --- a/fs/nfsd/nfs4state.c
>> +++ b/fs/nfsd/nfs4state.c
>> @@ -590,7 +590,7 @@ free_session(struct kref *kref)
>> ses = container_of(kref, struct nfsd4_session, se_ref);
>> for (i = 0; i < ses->se_fchannel.maxreqs; i++) {
>> struct nfsd4_cache_entry *e = &ses->se_slots[i].sl_cache_entry;
>> - nfsd4_release_respages(e->ce_respages, e->ce_resused);
>> + kfree(e->ce_datav.iov_base);
>> }
>> kfree(ses);
>> }
>> --
>> 1.5.4.3
>>
> _______________________________________________
> pNFS mailing list
> pNFS@linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>