From: andros@netapp.com
To: bfields@fieldses.org
Cc: pnfs@linux-nfs.org, linux-nfs@vger.kernel.org,
Andy Adamson <andros@netapp.com>
Subject: [PATCH 20/31] nfsd41: remove struct nfsd4_cache_entry
Date: Tue, 28 Apr 2009 12:59:54 -0400 [thread overview]
Message-ID: <1240938005-23778-20-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1240938005-23778-19-git-send-email-andros@netapp.com>
From: Andy Adamson <andros@netapp.com>
Replaced by fields in struct nfsd4_slot
Signed-off-by: Andy Adamson <andros@netapp.com>
---
fs/nfsd/nfs4state.c | 20 ++------------------
include/linux/nfsd/state.h | 27 +++++++--------------------
2 files changed, 9 insertions(+), 38 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 616ec0f..ff43793 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1030,13 +1030,11 @@ void
nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
{
struct nfsd4_slot *slot = resp->cstate.slot;
- struct nfsd4_cache_entry *entry = &resp->cstate.slot->sl_cache_entry;
struct svc_rqst *rqstp = resp->rqstp;
struct nfsd4_compoundargs *args = rqstp->rq_argp;
struct nfsd4_op *op = &args->ops[resp->opcnt];
- struct kvec *resv = &rqstp->rq_res.head[0];
- dprintk("--> %s entry %p\n", __func__, entry);
+ dprintk("--> %s\n", __func__);
/* Don't cache a failed OP_SEQUENCE. */
if (resp->opcnt == 1 && op->opnum == OP_SEQUENCE && resp->cstate.status)
@@ -1051,8 +1049,6 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
*/
if (nfsd4_not_cached(resp)) {
- entry->ce_resused = 0;
- entry->ce_rpchdrlen = 0;
slot->sl_datalen = 0;
dprintk("%s Just cache SEQUENCE. cachethis %d\n", __func__,
resp->cstate.slot->sl_cachethis);
@@ -1060,16 +1056,6 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
}
slot->sl_datalen = (char *)resp->p - (char *)resp->cstate.datap;
memcpy(slot->sl_data, resp->cstate.datap, slot->sl_datalen);
-
- entry->ce_resused = rqstp->rq_resused;
- if (entry->ce_resused > NFSD_PAGES_PER_SLOT + 1)
- entry->ce_resused = NFSD_PAGES_PER_SLOT + 1;
- entry->ce_datav.iov_base = resp->cstate.statp;
- entry->ce_datav.iov_len = resv->iov_len - ((char *)resp->cstate.statp -
- (char *)page_address(rqstp->rq_respages[0]));
- /* Current request rpc header length*/
- entry->ce_rpchdrlen = (char *)resp->cstate.statp -
- (char *)page_address(rqstp->rq_respages[0]);
}
/*
@@ -1081,10 +1067,9 @@ nfsd4_replay_cache_entry(struct nfsd4_compoundres *resp,
struct nfsd4_sequence *seq)
{
struct nfsd4_slot *slot = resp->cstate.slot;
- struct nfsd4_cache_entry *entry = &resp->cstate.slot->sl_cache_entry;
__be32 status;
- dprintk("--> %s entry %p\n", __func__, entry);
+ dprintk("--> %s datalen %d\n", __func__, slot->sl_datalen);
/*
* If this is just the sequence operation, we did not keep
@@ -1104,7 +1089,6 @@ nfsd4_replay_cache_entry(struct nfsd4_compoundres *resp,
/* The sequence operation has been encoded, cstate->datap set. */
memcpy(resp->cstate.datap, slot->sl_data, slot->sl_datalen);
- resp->rqstp->rq_resused = entry->ce_resused;
resp->opcnt = slot->sl_opcnt;
resp->p = resp->cstate.datap + XDR_QUADLEN(slot->sl_datalen);
status = slot->sl_status;
diff --git a/include/linux/nfsd/state.h b/include/linux/nfsd/state.h
index 8800e18..20d9958 100644
--- a/include/linux/nfsd/state.h
+++ b/include/linux/nfsd/state.h
@@ -107,31 +107,18 @@ struct nfs4_callback {
/* Maximum number of slots per session. 128 is useful for long haul TCP */
#define NFSD_MAX_SLOTS_PER_SESSION 128
-/* Maximum number of pages per slot cache entry */
-#define NFSD_PAGES_PER_SLOT 1
#define NFSD_SLOT_CACHE_SIZE 512
/* Maximum number of operations per session compound */
#define NFSD_MAX_OPS_PER_COMPOUND 16
-struct nfsd4_cache_entry {
- __be32 ce_status;
- struct kvec ce_datav; /* encoded NFSv4.1 data in rq_res.head[0] */
- struct page *ce_respages[NFSD_PAGES_PER_SLOT + 1];
- int ce_cachethis;
- short ce_resused;
- int ce_opcnt;
- int ce_rpchdrlen;
-};
-
struct nfsd4_slot {
- bool sl_inuse;
- u32 sl_seqid;
- int sl_cachethis;
- int sl_opcnt;
- __be32 sl_status;
- u32 sl_datalen;
- char sl_data[NFSD_SLOT_CACHE_SIZE];
- struct nfsd4_cache_entry sl_cache_entry;
+ bool sl_inuse;
+ u32 sl_seqid;
+ int sl_cachethis;
+ int sl_opcnt;
+ __be32 sl_status;
+ u32 sl_datalen;
+ char sl_data[NFSD_SLOT_CACHE_SIZE];
};
/*
--
1.5.4.3
next prev parent reply other threads:[~2009-04-28 17:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 16:59 [PATCH 01/31] nfsd41: slots are freed with session andros
2009-04-28 16:59 ` [PATCH 02/31] nfsd41: change check_slot_seqid parameters andros
2009-04-28 16:59 ` [PATCH 03/31] nfsd41: turn off create session caching andros
2009-04-28 16:59 ` [PATCH 04/31] nfsd41: separate clientid slot from session slot andros
2009-04-28 16:59 ` [PATCH 05/31] nfsd41: encode create_session result into cache andros
2009-04-28 16:59 ` [PATCH 06/31] nfsd41: create_session check replay first andros
2009-04-28 16:59 ` [PATCH 07/31] nfsd41: replay solo and embedded create session andros
2009-04-28 16:59 ` [PATCH 08/31] nfsd41: sanity check client drc maxreqs andros
2009-04-28 16:59 ` [PATCH 09/31] nfsd41: change from page to memory based drc limits andros
2009-04-28 16:59 ` [PATCH 10/31] nfsd41: use globals for DRC memory use management andros
2009-04-28 16:59 ` [PATCH 11/31] nfsd41: set the session maximum response size cached andros
2009-04-28 16:59 ` [PATCH 12/31] nfsd41: use static buffers for sessions DRC andros
2009-04-28 16:59 ` [PATCH 13/31] nfsd41: replace ce_cachethis with nfsd4_slot field andros
2009-04-28 16:59 ` [PATCH 14/31] nfsd41: replace ce_opcnt " andros
2009-04-28 16:59 ` [PATCH 15/31] nfsd41: nfsd41: replace ce_status " andros
2009-04-28 16:59 ` [PATCH 16/31] nfsd41: obliterate nfsd4_copy_pages andros
2009-04-28 16:59 ` [PATCH 17/31] nfsd41: obliterate nfsd41_copy_replay_data andros
2009-04-28 16:59 ` [PATCH 18/31] nfsd41: obliterate nfsd4_release_respages andros
2009-04-28 16:59 ` [PATCH 19/31] nfsd41: remove iovlen field from nfsd4_compound_state andros
2009-04-28 16:59 ` andros [this message]
2009-04-28 16:59 ` [PATCH 21/31] nfsd41: obliterate nfsd4_set_statp andros
2009-04-28 16:59 ` [PATCH 22/31] nfsd41: rename nfsd4_enc_uncached_replay andros
2009-04-28 16:59 ` [PATCH 23/31] nfsd41: encode replay sequence from the slot values andros
2009-04-28 16:59 ` [PATCH 24/31] nfsd41: fix nfsd4_replay_cache_entry comments andros
2009-04-28 16:59 ` [PATCH 25/31] nfsd41: fix nfsd4_store_cache_entry comments andros
2009-04-28 17:00 ` [PATCH 26/31] nfsd41: support 16 slots per session andros
2009-04-28 17:00 ` [PATCH 27/31] nfsd41: use the maximum operations per compound in nfsd4_compoundargs andros
2009-04-28 17:00 ` [PATCH 28/31] nfsd41: fix nfsd4_store_cache_entry dprintk andros
2009-04-28 17:00 ` [PATCH 29/31] nfsd41: add test for failed sequence operation andros
2009-04-28 17:00 ` [PATCH 30/31] nfsd41: remove redundant failed sequence check andros
2009-04-28 17:00 ` [PATCH 31/31] nfsd41: only reference the session on non-replay sequence andros
2009-04-30 23:08 ` [PATCH 10/31] nfsd41: use globals for DRC memory use management Benny Halevy
2009-05-01 14:39 ` Andy Adamson
2009-04-30 17:34 ` [PATCH 08/31] nfsd41: sanity check client drc maxreqs Benny Halevy
2009-04-30 18:43 ` Trond Myklebust
2009-05-15 23:08 ` [PATCH 07/31] nfsd41: replay solo and embedded create session J. Bruce Fields
2009-05-18 14:02 ` [pnfs] " William A. (Andy) Adamson
[not found] ` <89c397150905180702x6cecb802md9fed2f7f81e9aa1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-18 14:23 ` J. Bruce Fields
2009-05-18 14:42 ` William A. (Andy) Adamson
2009-05-15 23:05 ` [PATCH 05/31] nfsd41: encode create_session result into cache J. Bruce Fields
2009-05-18 13:54 ` [pnfs] " William A. (Andy) Adamson
2009-04-30 17:35 ` [PATCH 02/31] nfsd41: change check_slot_seqid parameters Benny Halevy
2009-04-30 19:34 ` Andy Adamson
2009-04-30 9:12 ` [PATCH 01/31] nfsd41: slots are freed with session Benny Halevy
2009-04-30 13:13 ` Andy Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240938005-23778-20-git-send-email-andros@netapp.com \
--to=andros@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox