From: "J. Bruce Fields" <bfields@fieldses.org>
To: linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@citi.umich.edu>
Subject: [PATCH] nfsd4: setclientid_confirm callback-change fixes
Date: Sun, 3 May 2009 14:16:29 -0400 [thread overview]
Message-ID: <1241374599-20348-4-git-send-email-bfields@fieldses.org> (raw)
In-Reply-To: <1241374599-20348-3-git-send-email-bfields@fieldses.org>
From: J. Bruce Fields <bfields@citi.umich.edu>
This setclientid_confirm case should allow the client to change
callbacks, but it currently has a dummy implementation that just turns
off callbacks completely. That dummy implementation isn't completely
correct either, though:
- There's no need to remove any client recovery directory in
this case.
- New clientid confirm verifiers should be generated (and
returned) in setclientid; there's no need to generate a new
one here.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---
fs/nfsd/nfs4state.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index d24dd12..7e1fcc3 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1688,8 +1688,6 @@ nfsd4_setclientid_confirm(struct svc_rqst *rqstp,
/* XXX: We just turn off callbacks until we can handle
* change request correctly. */
atomic_set(&conf->cl_callback.cb_set, 0);
- gen_confirm(conf);
- nfsd4_remove_clid_dir(unconf);
expire_client(unconf);
status = nfs_ok;
--
1.6.0.4
next prev parent reply other threads:[~2009-05-03 18:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 18:16 misc (mostly callback) patches for 2.6.31 J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: rename callback struct to cb_conn J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd: quiet compile warning J. Bruce Fields
2009-05-03 18:16 ` J. Bruce Fields [this message]
2009-05-03 18:16 ` [PATCH] nfsd4: set shorter timeout J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: set cb_client inside setup_callback_client J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: create rpc callback client from server thread J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: lookup up callback cred only once J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: replace callback thread by asynchronous rpc J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: rename callback struct to cb_conn J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: eliminate struct nfs4_cb_recall J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: remove unused dl_trunc J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: track recall retries in nfs4_delegation J. Bruce Fields
2009-05-03 18:16 ` [PATCH] nfsd4: make recall callback an asynchronous rpc J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241374599-20348-4-git-send-email-bfields@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox