From: Jeff Layton <jlayton@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: chuck.lever@oracle.com
Subject: [PATCH 2/3] nfs-utils: set IPV6_V6ONLY on nfssvc IPv6 sockets
Date: Mon, 11 May 2009 13:58:16 -0400 [thread overview]
Message-ID: <1242064697-32520-3-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1242064697-32520-1-git-send-email-jlayton@redhat.com>
IPv6 sockets for knfsd can't be allowed to accept IPv4 packets. Set the
correct option to prevent it.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
support/nfs/nfssvc.c | 26 +++++++++++++++++++++-----
1 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/support/nfs/nfssvc.c b/support/nfs/nfssvc.c
index c9b09dd..914bb3f 100644
--- a/support/nfs/nfssvc.c
+++ b/support/nfs/nfssvc.c
@@ -60,29 +60,37 @@ nfssvc_setfds(unsigned int ctlbits, struct sockaddr *sa, socklen_t addrlen)
int fd, on = 1;
char buf[BUFSIZ];
int udpfd = -1, tcpfd = -1;
+ unsigned short family = sa->sa_family;
fd = open(NFSD_PORTS_FILE, O_WRONLY);
if (fd < 0)
return;
if (NFSCTL_UDPISSET(ctlbits)) {
- udpfd = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP);
+ udpfd = socket(family, SOCK_DGRAM, IPPROTO_UDP);
if (udpfd < 0) {
- syslog(LOG_ERR, "nfssvc: unable to create UPD socket: "
+ syslog(LOG_ERR, "nfssvc: unable to create UDP socket: "
+ "errno %d (%s)\n", errno, strerror(errno));
+ exit(1);
+ }
+ if (family == AF_INET6 && setsockopt(udpfd, IPPROTO_IPV6,
+ IPV6_V6ONLY, &on,
+ sizeof(on))) {
+ syslog(LOG_ERR, "nfssvc: unable to set IPV6_V6ONLY: "
"errno %d (%s)\n", errno, strerror(errno));
exit(1);
}
if (bind(udpfd, sa, addrlen) < 0) {
- syslog(LOG_ERR, "nfssvc: unable to bind UPD socket: "
+ syslog(LOG_ERR, "nfssvc: unable to bind UDP socket: "
"errno %d (%s)\n", errno, strerror(errno));
exit(1);
}
}
if (NFSCTL_TCPISSET(ctlbits)) {
- tcpfd = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
+ tcpfd = socket(family, SOCK_STREAM, IPPROTO_TCP);
if (tcpfd < 0) {
- syslog(LOG_ERR, "nfssvc: unable to createt tcp socket: "
+ syslog(LOG_ERR, "nfssvc: unable to createt TCP socket: "
"errno %d (%s)\n", errno, strerror(errno));
exit(1);
}
@@ -91,6 +99,14 @@ nfssvc_setfds(unsigned int ctlbits, struct sockaddr *sa, socklen_t addrlen)
"errno %d (%s)\n", errno, strerror(errno));
exit(1);
}
+ if (family == AF_INET6 && setsockopt(tcpfd, IPPROTO_IPV6,
+ IPV6_V6ONLY, &on,
+ sizeof(on))) {
+ syslog(LOG_ERR, "nfssvc: unable to set IPV6_V6ONLY: "
+ "errno %d (%s)\n", errno, strerror(errno));
+ exit(1);
+ }
+
if (bind(tcpfd, sa, addrlen) < 0) {
syslog(LOG_ERR, "nfssvc: unable to bind TCP socket: "
"errno %d (%s)\n", errno, strerror(errno));
--
1.6.0.6
next prev parent reply other threads:[~2009-05-11 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 17:58 [PATCH 0/3] nfs-utils: add IPv6 support to rpc.nfsd (RFC) Jeff Layton
2009-05-11 17:58 ` [PATCH 1/3] nfs-utils: rearrange nfssvc.c Jeff Layton
2009-05-11 17:58 ` Jeff Layton [this message]
2009-05-11 17:58 ` [PATCH 3/3] nfs-utils: add IPv6 support to nfsd Jeff Layton
2009-05-11 19:34 ` Chuck Lever
2009-05-18 15:42 ` Steve Dickson
[not found] ` <4A1181EE.7080401-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-05-18 15:48 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242064697-32520-3-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox