public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: andros@netapp.com
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, Andy Adamson <andros@netapp.com>
Subject: [PATCH 10/30] nfsd41: set the session maximum response size cached
Date: Mon,  8 Jun 2009 14:20:51 -0400	[thread overview]
Message-ID: <1244485271-7461-11-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1244485271-7461-10-git-send-email-andros@netapp.com>

From: Andy Adamson <andros@netapp.com>

We don't cache the SEQUENCE operation because we can encode it from the session
slot values, so it is not included in NFSD_SLOT_CACHE_SIZE.

Fix the nfsd4_check_drc_limit() comment - the cache is no longer page based.

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 fs/nfsd/nfs4state.c |   10 +++++++---
 fs/nfsd/nfs4xdr.c   |    2 --
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index db56a8a..cdc2a5e 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -448,6 +448,12 @@ static int set_forechannel_maxreqs(struct nfsd4_channel_attrs *fchan)
 	}
 }
 
+/* rpc header + encoded OP_SEQUENCE reply + NFSD_SLOT_CACHE_SIZE in bytes */
+#define NFSD_MAX_RESPONSE_CACHED  ((RPC_MAX_HEADER_WITH_AUTH + \
+				  2 + /* OP_SEQUENCE header */ \
+				  XDR_QUADLEN(NFS4_MAX_SESSIONID_LEN) + 5 + \
+				  XDR_QUADLEN(NFSD_SLOT_CACHE_SIZE)) << 2)
+
 /*
  * fchan holds the client values on input, and the server values on output
  */
@@ -469,9 +475,7 @@ static int init_forechannel_attrs(struct svc_rqst *rqstp,
 		fchan->maxresp_sz = maxcount;
 	session->se_fmaxresp_sz = fchan->maxresp_sz;
 
-	/* Set the max response cached size our default which is
-	 * a multiple of PAGE_SIZE and small */
-	session->se_fmaxresp_cached = NFSD_PAGES_PER_SLOT * PAGE_SIZE;
+	session->se_fmaxresp_cached = NFSD_MAX_RESPONSE_CACHED;
 	fchan->maxresp_cached = session->se_fmaxresp_cached;
 
 	/* Use the client's maxops if possible */
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index b73549d..7e6b139 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -3176,8 +3176,6 @@ static nfsd4_enc nfsd4_enc_ops[] = {
  *
  * Compare this length to the session se_fmaxresp_cached.
  *
- * Our se_fmaxresp_cached will always be a multiple of PAGE_SIZE, and so
- * will be at least a page and will therefore hold the xdr_buf head.
  */
 static int nfsd4_check_drc_limit(struct nfsd4_compoundres *resp)
 {
-- 
1.5.4.3


  reply	other threads:[~2009-06-08 18:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 18:20 [PATCH 0/30] NFSv4.1 Server DRC rewrite Version 3 andros
2009-06-08 18:20 ` [PATCH 01/30] nfsd41: create_session check replay first andros
2009-06-08 18:20   ` [PATCH 02/30] nfsd41: change check_slot_seqid parameters andros
2009-06-08 18:20     ` [PATCH 03/30] nfsd41: declare clientid create session slot structure andros
2009-06-08 18:20       ` [PATCH 04/30] nfsd41: encode create_session result into clid cache andros
2009-06-08 18:20         ` [PATCH 05/30] nfsd41: replay solo and embedded create session andros
2009-06-08 18:20           ` [PATCH 06/30] nfsd41 remove the unused nfsd4_slot create session slot andros
2009-06-08 18:20             ` [PATCH 07/30] nfsd41: sanity check client drc maxreqs andros
2009-06-08 18:20               ` [PATCH 08/30] nfsd41: change from page to memory based drc limits andros
2009-06-08 18:20                 ` [PATCH 09/30] nfsd41: use globals for DRC memory use management andros
2009-06-08 18:20                   ` andros [this message]
2009-06-08 18:20                     ` [PATCH 11/30] nfsd41: use static buffers for sessions DRC andros
2009-06-08 18:20                       ` [PATCH 12/30] nfsd41: replace ce_cachethis with nfsd4_slot field andros
2009-06-08 18:20                         ` [PATCH 13/30] nfsd41: replace ce_opcnt " andros
2009-06-08 18:20                           ` [PATCH 14/30] nfsd41: nfsd41: replace ce_status " andros
2009-06-08 18:20                             ` [PATCH 15/30] nfsd41: obliterate nfsd4_copy_pages andros
2009-06-08 18:20                               ` [PATCH 16/30] nfsd41: obliterate nfsd41_copy_replay_data andros
2009-06-08 18:20                                 ` [PATCH 17/30] nfsd41: obliterate nfsd4_release_respages andros
2009-06-08 18:20                                   ` [PATCH 18/30] nfsd41: remove iovlen field from nfsd4_compound_state andros
2009-06-08 18:21                                     ` [PATCH 19/30] nfsd41: remove struct nfsd4_cache_entry andros
2009-06-08 18:21                                       ` [PATCH 20/30] nfsd41: obliterate nfsd4_set_statp andros
2009-06-08 18:21                                         ` [PATCH 21/30] nfsd41: rename nfsd4_enc_uncached_replay andros
2009-06-08 18:21                                           ` [PATCH 22/30] nfsd41: encode replay sequence from the slot values andros
2009-06-08 18:21                                             ` [PATCH 23/30] nfsd41: fix nfsd4_replay_cache_entry comments andros
2009-06-08 18:21                                               ` [PATCH 24/30] nfsd41: fix nfsd4_store_cache_entry comments andros
2009-06-08 18:21                                                 ` [PATCH 25/30] nfsd41: support 16 slots per session andros
2009-06-08 18:21                                                   ` [PATCH 26/30] nfsd41: use the maximum operations per compound in nfsd4_compoundargs andros
2009-06-08 18:21                                                     ` [PATCH 27/30] nfsd41: fix nfsd4_store_cache_entry dprintk andros
2009-06-08 18:21                                                       ` [PATCH 28/30] nfsd41: add test for failed sequence operation andros
2009-06-08 18:21                                                         ` [PATCH 29/30] nfsd41: remove redundant failed sequence check andros
2009-06-08 18:21                                                           ` [PATCH 30/30] nfsd41: only reference the session on non-replay sequence andros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244485271-7461-11-git-send-email-andros@netapp.com \
    --to=andros@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox