public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
To: trond.myklebust@netapp.com
Cc: bhalevy@panasas.com, pnfs@linux-nfs.org,
	linux-nfs@vger.kernel.org,
	Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
Subject: [PATCH 2/3] SQUASHME: nfs41: Backchannel: Remove FIXME comment
Date: Tue, 16 Jun 2009 11:26:39 -0700	[thread overview]
Message-ID: <1245176800-10595-2-git-send-email-Ricardo.Labiaga@netapp.com> (raw)
In-Reply-To: <1245176800-10595-1-git-send-email-Ricardo.Labiaga@netapp.com>

We already correctly monitor and manage the callback service for NFSv4
and NFSv4.1.  Remove the comment calling attention to this.

[squash with: nfs41: minorversion support for nfs4_{init,destroy}_callback]

Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
---
 fs/nfs/callback.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
index f874640..e69b8f6 100644
--- a/fs/nfs/callback.c
+++ b/fs/nfs/callback.c
@@ -265,8 +265,6 @@ int nfs_callback_up(u32 minorversion, struct rpc_xprt *xprt)
 		goto out_err;
 	}
 
-	/* FIXME: either 4.0 or 4.1 callback service can be up at a time
-	 * need to monitor and control them both */
 	minorversion_setup =  nfs_minorversion_callback_svc_setup(minorversion,
 					serv, xprt, &rqstp, &callback_svc);
 	if (!minorversion_setup) {
-- 
1.5.4.3


  reply	other threads:[~2009-06-16 18:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 18:26 [PATCH 1/3] nfs41: SQUASHME: Update to removal of ugly #ifdefs Ricardo Labiaga
2009-06-16 18:26 ` Ricardo Labiaga [this message]
2009-06-16 18:26   ` [PATCH 3/3] SQUASHME: nfs41: Backchannel: Be more obvious about the return value Ricardo Labiaga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245176800-10595-2-git-send-email-Ricardo.Labiaga@netapp.com \
    --to=ricardo.labiaga@netapp.com \
    --cc=bhalevy@panasas.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=pnfs@linux-nfs.org \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox