From: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
To: bfields@fieldses.org
Cc: bhalevy@panasas.com, pnfs@linux-nfs.org,
linux-nfs@vger.kernel.org,
Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
Subject: [PATCH 1/1] nfsd41: renew_client() needs to be called with the client_mutex held
Date: Wed, 17 Jun 2009 18:50:45 -0700 [thread overview]
Message-ID: <1245289845-12118-1-git-send-email-Ricardo.Labiaga@netapp.com> (raw)
In-Reply-To: <>
renew_client() manipulates the client queue for lease renewal. Need to
obtain the client_mutex before manipulating it.
Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
---
fs/nfsd/nfs4state.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 4cb5d1d..18258d7 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1537,7 +1537,9 @@ replay_cache:
* Hold a session reference until done processing the compound:
* nfsd4_put_session called only if the cstate slot is set.
*/
+ nfs4_lock_state();
renew_client(session->se_client);
+ nfs4_unlock_state();
nfsd4_get_session(session);
out:
spin_unlock(&sessionid_lock);
--
1.5.4.3
next reply other threads:[~2009-06-18 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 1:50 Ricardo Labiaga [this message]
2009-06-18 17:31 ` [PATCH 1/1] nfsd41: renew_client() needs to be called with the client_mutex held J. Bruce Fields
2009-06-18 17:39 ` Labiaga, Ricardo
2009-06-18 17:48 ` J. Bruce Fields
2009-06-18 17:51 ` Labiaga, Ricardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245289845-12118-1-git-send-email-Ricardo.Labiaga@netapp.com \
--to=ricardo.labiaga@netapp.com \
--cc=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox