From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Kennedy Subject: [PATCH] nfs: reorder nfs4_sequence_regs to remove 8 bytes of padding on 64 bits Date: Tue, 27 Oct 2009 17:50:12 +0000 Message-ID: <1256665813.2319.26.camel@castor> Mime-Version: 1.0 Content-Type: text/plain Cc: linux-nfs@vger.kernel.org, lkml To: Trond Myklebust Return-path: Received: from anchor-post-1.mail.demon.net ([195.173.77.132]:42727 "EHLO anchor-post-1.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756465AbZJ0RuN (ORCPT ); Tue, 27 Oct 2009 13:50:13 -0400 Sender: linux-nfs-owner@vger.kernel.org List-ID: reorder nfs4_sequence_args to remove 8 bytes of padding on 64 bit builds. The size of this structure drops to 24 bytes from 32 and reduces the text size of nfs.ko. On my x86_64 size reports text data bss 2.6.32-rc5 200996 8512 432 209940 33414 nfs.ko +patch 200884 8512 432 209828 333a4 nfs.ko Signed-off-by: Richard Kennedy ---- patch against 2.6.32-rc5 only lightly tested but it seems to work both with 64 bit client -> 32 bit server & 32 bit client -> 64 bit server. regards Richard diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h index 62f63fb..8c88037 100644 --- a/include/linux/nfs_xdr.h +++ b/include/linux/nfs_xdr.h @@ -170,8 +170,8 @@ struct nfs4_sequence_args { struct nfs4_sequence_res { struct nfs4_session *sr_session; u8 sr_slotid; /* slot used to send request */ - unsigned long sr_renewal_time; int sr_status; /* sequence operation status */ + unsigned long sr_renewal_time; }; struct nfs4_get_lease_time_args {