From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/3] nfs41: Mark stateids in need of reclaim if state manager gets stale clientid
Date: Sat, 05 Dec 2009 15:34:13 -0500 [thread overview]
Message-ID: <1260045253.29208.6.camel@localhost> (raw)
In-Reply-To: <1260043884-16267-2-git-send-email-Ricardo.Labiaga@netapp.com>
On Sat, 2009-12-05 at 12:11 -0800, Ricardo Labiaga wrote:
> The state manager was not marking the stateids as needing to be reclaimed
> after reestablishing the clientid.
>
> Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
> ---
> fs/nfs/nfs4state.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
> index 630199d..ae90df8 100644
> --- a/fs/nfs/nfs4state.c
> +++ b/fs/nfs/nfs4state.c
> @@ -1157,6 +1157,7 @@ static void nfs4_session_recovery_handle_error(struct nfs_client *clp, int err)
> case -NFS4ERR_STALE_CLIENTID:
> set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state);
> set_bit(NFS4CLNT_SESSION_SETUP, &clp->cl_state);
> + nfs4_state_start_reclaim_reboot(clp);
> }
> }
>
So, why do we need a special nfs4_session_recovery_handle_error() that
just mirrors the existing nfs4_recovery_handle_error().
Please just get rid of it...
Trond
next prev parent reply other threads:[~2009-12-05 20:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-05 20:11 [Patch 0/3] Reclaim State Bug Fixes Ricardo Labiaga
2009-12-05 20:11 ` [PATCH 1/3] nfs41: Mark stateids in need of reclaim if state manager gets stale clientid Ricardo Labiaga
2009-12-05 20:11 ` [PATCH 2/3] nfs41: Handle session errors during delegation return Ricardo Labiaga
2009-12-05 20:11 ` [PATCH 3/3] nfs41: Retry delegation return if it failed with session error Ricardo Labiaga
2009-12-05 20:39 ` Trond Myklebust
2009-12-05 20:38 ` [PATCH 2/3] nfs41: Handle session errors during delegation return Trond Myklebust
2009-12-05 21:58 ` Labiaga, Ricardo
2009-12-05 20:34 ` Trond Myklebust [this message]
2009-12-05 21:12 ` [PATCH 1/3] nfs41: Mark stateids in need of reclaim if state manager gets stale clientid Labiaga, Ricardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260045253.29208.6.camel@localhost \
--to=trond.myklebust@netapp.com \
--cc=Ricardo.Labiaga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox