From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Trond Myklebust <trond@netapp.com>, linux-nfs@vger.kernel.org
Subject: Re: null dereference in nfs4_begin_drain_session
Date: Tue, 15 Dec 2009 17:32:00 -0500 [thread overview]
Message-ID: <1260916320.3219.1.camel@localhost> (raw)
In-Reply-To: <20091215222449.GD8686@fieldses.org>
On Tue, 2009-12-15 at 17:24 -0500, J. Bruce Fields wrote:
> I got this just now on a test client running a branch including (among
> other stuff) your 72211dbe727f7c1451aa5adfcbd1197b090eb276. Looks like
> it was trying to run cthon tests over v4.0. Anything known? Let me
> know if you want anything more.
>
> --b.
>
> BUG: unable to handle kernel NULL pointer dereference at 00000088
> IP: [<c105b2bb>] __lock_acquire+0x21b/0x1880
> *pde = 00000000
> Oops: 0000 [#1] PREEMPT
> last sysfs file: /sys/kernel/uevent_seqnum
> Modules linked in:
>
> Pid: 3137, comm: 192.168.122.129 Not tainted 2.6.32-07559-g0adf9c1 #553 /
> EIP: 0060:[<c105b2bb>] EFLAGS: 00010046 CPU: 0
> EIP is at __lock_acquire+0x21b/0x1880
> EAX: 00000084 EBX: c6be42a0 ECX: 00000000 EDX: 00000001
> ESI: 00000002 EDI: 00000000 EBP: c6bfff10 ESP: c6bffe9c
> DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068
> Process 192.168.122.129 (pid: 3137, ti=c6bfe000 task=c6be42a0 task.ti=c6bfe000)
> Stack:
> 00000046 00000046 00000000 00000000 00000000 00000000 00000000 c1b8a3e0
> <0> c6bfff0c c1ead970 c6be4760 00000041 c20d6b48 00000084 00000000 00000000
> <0> 00000000 00000000 0000094d 00000000 c1b8a3e0 c6bfff40 c10277f8 c6bfff00
> Call Trace:
> [<c10277f8>] ? update_curr+0x208/0x270
> [<c105c99e>] ? lock_acquire+0x7e/0x110
> [<c120a628>] ? nfs4_begin_drain_session+0x28/0x80
> [<c188f5d2>] ? _raw_spin_lock+0x42/0x50
> [<c120a628>] ? nfs4_begin_drain_session+0x28/0x80
> [<c120a628>] ? nfs4_begin_drain_session+0x28/0x80
> [<c120b1e0>] ? nfs4_run_state_manager+0x0/0x430
> [<c120b3e7>] ? nfs4_run_state_manager+0x207/0x430
> [<c120b1e0>] ? nfs4_run_state_manager+0x0/0x430
> [<c104ae54>] ? kthread+0x74/0x80
> [<c104ade0>] ? kthread+0x0/0x80
> [<c100333b>] ? kernel_thread_helper+0x7/0x10
> Code: fe ff ff e8 e8 ff 47 00 85 c0 74 dc 83 3d 20 0d 2a c2 00 75 d3 b8 75 6f a7 c1 ba b6 0a 00 00 e8 6c 2b fd ff 31 c0 eb c2 8b 45 c0 <8b> 40 04 85 c0 89 45 c8 0f 84 2b fe ff ff a1 c0 76 c7 c1 85 c0
> EIP: [<c105b2bb>] __lock_acquire+0x21b/0x1880 SS:ESP 0068:c6bffe9c
> CR2: 0000000000000088
> ---[ end trace 93dafd3a9c985071 ]---
> note: 192.168.122.129[3137] exited with preempt_count 1
>
Argh! This is exactly why I wanted those nfs4_begin_drain_session()
calls out of the state manager main loop. They _only_ make sense for the
NFSv4.1 code path, damnit!
Trond
next prev parent reply other threads:[~2009-12-15 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 22:24 null dereference in nfs4_begin_drain_session J. Bruce Fields
2009-12-15 22:32 ` Trond Myklebust [this message]
2009-12-15 22:52 ` Trond Myklebust
2009-12-17 22:54 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260916320.3219.1.camel@localhost \
--to=trond.myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox