From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH] sunrpc: on successful gss error pipe write, don't return error (try #3)
Date: Fri, 18 Dec 2009 16:30:18 -0500 [thread overview]
Message-ID: <1261171818.3420.71.camel@localhost> (raw)
In-Reply-To: <1261171430-15075-1-git-send-email-jlayton@redhat.com>
On Fri, 2009-12-18 at 16:23 -0500, Jeff Layton wrote:
> When handling the gssd downcall, the kernel should distinguish between a
> successful downcall that contains an error code and a failed downcall
> (i.e. where the parsing failed or some other sort of problem occurred).
>
> In the former case, gss_pipe_downcall should be returning the number of
> bytes written to the pipe instead of an error. In the event of other
> errors, we generally want the initiating task to retry the upcall so
> we set msg.errno to -EAGAIN. An unexpected error code here is a bug
> however, so BUG() in that case.
That looks good. I'll apply it after the two other fixes.
Trond
prev parent reply other threads:[~2009-12-18 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 21:23 [PATCH] sunrpc: on successful gss error pipe write, don't return error (try #3) Jeff Layton
2009-12-18 21:30 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261171818.3420.71.camel@localhost \
--to=trond.myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).