Re: [PATCH 1/6] VFS: Ensure that writeback_single_inode() commits unstable writes

Trond Myklebust
2010-01-08T14:15:05Z

On Fri, 2010-01-08 at 08:54 -0500, Christoph Hellwig wrote:
> On Fri, Jan 08, 2010 at 08:46:46AM -0500, Trond Myklebust wrote:
> > Could we in that case replace write_inode() with something that takes a
> > struct writeback_control? It is very useful to have full information
> > about the write range and flags as it allows us to tweak the COMMIT RPC
> > call.
>
> At this point I do not plan to change the write_inode interface. But
> changing the ->write_inode operation to take a writeback control instead
> of the sync flag should be a prety easy change if you want to do it.
>

OK. Please could you let me know when you're done with your changes so
that I can adapt this patch?

Cheers
Trond