Linux NFS development
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "Batsakis, Alexandros" <Alexandros.Batsakis@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: RE: [PATCH 1/1] nfs: fix race between renewd, umount, and the state manager in V4.1
Date: Fri, 22 Jan 2010 15:21:20 -0500	[thread overview]
Message-ID: <1264191680.30757.33.camel@localhost> (raw)
In-Reply-To: <1264191084.30757.28.camel@localhost>

On Fri, 2010-01-22 at 15:11 -0500, Trond Myklebust wrote: 
> Then the correct thing to do is to fix the renewd kill process. Once
> that is done, there should be no reason for any sequence_done calls to
> be pending (see reason above).

IOW: we should add a call to atomic_inc_not_zero(&clp->cl_count) in
nfs4_proc_async_renew()/nfs41_proc_async_sequence(), and have them fail
if that attempt to grab a reference fails. Then we should add a call to
nfs_put_client() in their .rpc_release method.

Trond


  reply	other threads:[~2010-01-22 20:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22  4:51 [PATCH 1/1] nfs: fix race between renewd, umount, and the state manager in V4.1 Alexandros Batsakis
2010-01-22 18:47 ` Trond Myklebust
2010-01-22 19:30   ` Batsakis, Alexandros
     [not found]     ` <B9364369CA66BF45806C2CD86EAB8BA604F35537-hX7t0kiaRRqx3DEm5hsDiAK/GNPrWCqfQQ4Iyu8u01E@public.gmane.org>
2010-01-22 19:41       ` Trond Myklebust
2010-01-22 20:01         ` Batsakis, Alexandros
     [not found]           ` <B9364369CA66BF45806C2CD86EAB8BA604F35581-hX7t0kiaRRqx3DEm5hsDiAK/GNPrWCqfQQ4Iyu8u01E@public.gmane.org>
2010-01-22 20:11             ` Trond Myklebust
2010-01-22 20:21               ` Trond Myklebust [this message]
2010-01-22 20:24                 ` Batsakis, Alexandros
  -- strict thread matches above, loose matches on Subject: below --
2010-01-14  0:15 Alexandros Batsakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264191680.30757.33.camel@localhost \
    --to=trond.myklebust@fys.uio.no \
    --cc=Alexandros.Batsakis@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox