From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: andros@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] nfs41 do not allocate unused back channel pages
Date: Thu, 28 Jan 2010 09:09:56 -0500 [thread overview]
Message-ID: <1264687796.3724.1.camel@localhost> (raw)
In-Reply-To: <1264556989-7409-1-git-send-email-andros@netapp.com>
On Tue, 2010-01-26 at 20:49 -0500, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
>
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
> net/sunrpc/svc.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 538ca43..c9991e8 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -506,6 +506,12 @@ svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
> {
> unsigned int pages, arghi;
>
> +#if defined(CONFIG_NFS_V4_1)
> + /* bc_xprt uses fore channel allocated buffers */
> + if (rqstp->rq_server->bc_xprt)
> + return 1;
> +#endif /* CONFIG_NFS_V4_1 */
> +
> pages = size / PAGE_SIZE + 1; /* extra page as we hold both request and reply.
> * We assume one is at most one page
> */
Can we replace this with a 'svc_is_backchannel(rqstp->rq_server)' type
of test? That would make it a bit easier on the eyes.
next prev parent reply other threads:[~2010-01-28 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 1:49 [PATCH 1/1] nfs41 do not allocate unused back channel pages andros
2010-01-28 14:09 ` Trond Myklebust [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-27 2:24 andros
2010-01-26 17:55 andros
2010-01-27 23:44 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264687796.3724.1.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=andros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox