From: andros@netapp.com
To: pnfs@linux-nfs.org
Cc: linux-nfs@vger.kernel.org, Andy Adamson <andros@netapp.com>
Subject: [PATCH 3/5] pnfsd: DLM file layout only support read iomode layouts
Date: Fri, 5 Feb 2010 12:10:11 -0500 [thread overview]
Message-ID: <1265389813-6823-4-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1265389813-6823-3-git-send-email-andros@netapp.com>
From: Andy Adamson <andros@netapp.com>
In a DLM cluster, writing to a node other than the node where the open call
occurred and where meta data is cached will have performance implications when
the write causes meta data changes that need to be propagated to the open call
node.
DlM clusters support only LAYOUTIOMODE4_READ layouts. Writes will go through
the MDS.
Return NFS4ERR_BADIOMODE for LAYOUTGET requests with LAYOUTIOMODE4_RW iomode.
Signed-off-by: Andy Adamson <andros@netapp.com>
---
fs/nfsd/nfs4pnfsd.c | 2 ++
fs/nfsd/nfs4pnfsdlm.c | 5 +++++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/fs/nfsd/nfs4pnfsd.c b/fs/nfsd/nfs4pnfsd.c
index 3951e02..e1ecf81 100644
--- a/fs/nfsd/nfs4pnfsd.c
+++ b/fs/nfsd/nfs4pnfsd.c
@@ -881,6 +881,8 @@ nfs4_pnfs_get_layout(struct nfsd4_pnfs_layoutget *lgp,
case -ENOENT:
status = nfserr_stale;
break;
+ case nfserr_badiomode:
+ break;
default:
status = nfserr_layoutunavailable;
}
diff --git a/fs/nfsd/nfs4pnfsdlm.c b/fs/nfsd/nfs4pnfsdlm.c
index 293bf95..8cc7c84 100644
--- a/fs/nfsd/nfs4pnfsdlm.c
+++ b/fs/nfsd/nfs4pnfsdlm.c
@@ -28,6 +28,7 @@
#include <linux/nfsd/nfs4layoutxdr.h>
#include "nfsfh.h"
+#include "nfsd.h"
#define NFSDDBG_FACILITY NFSDDBG_PROC
@@ -331,6 +332,10 @@ static int nfsd4_pnfs_dlm_layoutget(struct inode *inode,
dprintk("%s: LAYOUT_GET\n", __func__);
+ /* DLM exported file systems only support layouts for READ */
+ if (res->lg_seg.iomode == IOMODE_RW)
+ return nfserr_badiomode;
+
index = dlm_ino_hash(inode);
dprintk("%s first stripe index %d i_ino %lu\n", __func__, index,
inode->i_ino);
--
1.6.6
next prev parent reply other threads:[~2010-02-05 17:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 17:10 [PATCH 0/5] pnfs DLM cluster only use read iomode layouts andros
2010-02-05 17:10 ` [PATCH 1/5] pnfsd: fix NFS4ERR_BADIOMODE in layoutget andros
2010-02-05 17:10 ` [PATCH 2/5] pnfsd: fix pnfs_export_operations layoutget valid errors andros
2010-02-05 17:10 ` andros [this message]
2010-02-05 17:10 ` [PATCH 4/5] pnfsd: fix DLM file layout no device return andros
2010-02-05 17:10 ` [PATCH 5/5] pnfs: set failed layout bit per iomode andros
2010-02-07 9:33 ` [pnfs] [PATCH 4/5] pnfsd: fix DLM file layout no device return Boaz Harrosh
2010-02-07 9:26 ` [pnfs] [PATCH 3/5] pnfsd: DLM file layout only support read iomode layouts Boaz Harrosh
2010-02-07 9:05 ` [pnfs] [PATCH 2/5] pnfsd: fix pnfs_export_operations layoutget valid errors Benny Halevy
2010-02-08 20:41 ` Andy Adamson
2010-02-08 21:01 ` J. Bruce Fields
2010-02-09 8:34 ` Boaz Harrosh
2010-02-09 12:52 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265389813-6823-4-git-send-email-andros@netapp.com \
--to=andros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox