Re: [PATCH 2/2] NFS: Fix the mapping of the NFSERR_SERVERFAULT error

[Trond Myklebust <Trond.Myklebust@netapp.com>]

On Fri, 2010-02-05 at 18:12 -0500, Chuck Lever wrote: 
> On 02/05/2010 05:43 PM, Trond Myklebust wrote:
> > It was recently pointed out that the NFSERR_SERVERFAULT error, which is
> > designed to inform the user of a serious internal error on the server, was
> > being mapped to an error value that is internal to the kernel.
> >
> > This patch maps it to the error EREMOTEIO, which is exported to userland
> > through errno.h.
> >
> > Signed-off-by: Trond Myklebust<Trond.Myklebust@netapp.com>
> > Cc: stable@kernel.org
> > ---
> >   fs/nfs/mount_clnt.c |    2 +-
> >   fs/nfs/nfs2xdr.c    |    2 +-
> >   fs/nfs/nfs4xdr.c    |    6 +++---
> >   3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c
> > index 0adefc4..59047f8 100644
> > --- a/fs/nfs/mount_clnt.c
> > +++ b/fs/nfs/mount_clnt.c
> > @@ -120,7 +120,7 @@ static struct {
> >   	{ .status = MNT3ERR_INVAL,		.errno = -EINVAL,	},
> >   	{ .status = MNT3ERR_NAMETOOLONG,	.errno = -ENAMETOOLONG,	},
> >   	{ .status = MNT3ERR_NOTSUPP,		.errno = -ENOTSUPP,	},
> > -	{ .status = MNT3ERR_SERVERFAULT,	.errno = -ESERVERFAULT,	},
> > +	{ .status = MNT3ERR_SERVERFAULT,	.errno = -EREMOTEIO,	},
> >   };
> >
> >   struct mountres {
> 
> The decode_status() and decode_fhs_status() functions return -EACCES if 
> they don't recognize the server's error code.  Should they return 
> -EREMOTEIO instead?

It might possibly be a bit more enlightening to the user, but that would
be a separate patch. I wouldn't see that fix as being particularly
critical: EACCES is a valid error code that can be returned to userland.

Cheers
  Trond