From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Neil Brown <neilb@suse.de>
Cc: linux-nfs@vger.kernel.org
Subject: Re: Possible-Patch: unregister bdi on error path.
Date: Wed, 10 Mar 2010 19:40:33 -0500 [thread overview]
Message-ID: <1268268033.22310.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20100311112231.7db30fd5-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
On Thu, 2010-03-11 at 11:22 +1100, Neil Brown wrote:
> On Wed, 10 Mar 2010 18:01:47 -0500
> Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> > Yes. It looks as if you have indeed found a bug.
> >
> > My main comment is that in order to be complete the patch should also
> > address the cases of nfs_xdev_get_sb(), nfs4_remote_get_sb(),
> > nfs4_xdev_get_sb(), and nfs4_remote_referral_get_sb(). They appear to
> > suffer from the same problem...
> >
>
> Good point. Patch follows.
> I have compile-tested this but nothing more. I'm not even sure how I can
> test it as it only affect error paths that are not easy to force.
Agreed that it is faith based patching :-) but I'm willing to go with
that unless someone can show me that your argument is incorrect.
Will apply...
Cheers
Trond
prev parent reply other threads:[~2010-03-11 0:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 22:13 Possible-Patch: unregister bdi on error path Neil Brown
[not found] ` <19352.6543.377883.277948-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2010-03-10 23:01 ` Trond Myklebust
[not found] ` <1268262107.3096.207.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-11 0:22 ` Neil Brown
[not found] ` <20100311112231.7db30fd5-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2010-03-11 0:40 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268268033.22310.5.camel@localhost.localdomain \
--to=trond.myklebust@fys.uio.no \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox