From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH] NFS: don't try to decode GETATTR if DELEGRETURN returned error
Date: Sun, 21 Mar 2010 12:15:33 -0400 [thread overview]
Message-ID: <1269188133.3215.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1269170258-31596-1-git-send-email-jlayton@redhat.com>
On Sun, 2010-03-21 at 07:17 -0400, Jeff Layton wrote:
> The reply parsing code attempts to decode the GETATTR response even if
> the DELEGRETURN portion of the compound returned an error. The GETATTR
> response won't actually exist if that's the case and we're asking the
> parser to read past the end of the response.
>
> This bug is fairly benign. The parser catches this without reading past
> the end of the response and decode_getfattr returns -EIO. Earlier
> kernels however had decode_op_hdr using the READ_BUF macro, and this
> bug would make this printk pop any time the client got an error from
> a delegreturn:
>
> kernel: decode_op_hdr: reply buffer overflowed in line XXXX
>
> More recent kernels seem to have replaced this printk with a dprintk.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Applied. Thanks!
Trond
prev parent reply other threads:[~2010-03-21 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 11:17 [PATCH] NFS: don't try to decode GETATTR if DELEGRETURN returned error Jeff Layton
2010-03-21 16:15 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269188133.3215.1.camel@localhost.localdomain \
--to=trond.myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox